diff options
author | Rafael Espindola <rafael.espindola@gmail.com> | 2013-02-23 00:26:28 +0000 |
---|---|---|
committer | Rafael Espindola <rafael.espindola@gmail.com> | 2013-02-23 00:26:28 +0000 |
commit | 16c8cf0e11dd7f53d3a50609d5821f56e6b52c1a (patch) | |
tree | eb36aec59db85b432616af7aa244a275efdaa82f /clang/test/CodeGenCXX/c-linkage.cpp | |
parent | 47f9f2d1e670f700f18800a09c2a4fcd410658aa (diff) | |
download | bcm5719-llvm-16c8cf0e11dd7f53d3a50609d5821f56e6b52c1a.tar.gz bcm5719-llvm-16c8cf0e11dd7f53d3a50609d5821f56e6b52c1a.zip |
Remove the hack that avoided mangling static functions in extern C contexts.
Weather we should give C language linkage to functions and variables with
internal linkage probably depends on how much code assumes it. The standard
says they should have no language linkage, but gcc and msvc assign them
C language linkage.
This commit removes the hack that was preventing the mangling on static
functions declare in extern C contexts. It is an experiment to see if we
can implement the rules in the standard.
If it turns out that many users depend on these functions and variables
having C language linkage, we should change isExternC instead and try
to convince the CWG to change the standard.
llvm-svn: 175937
Diffstat (limited to 'clang/test/CodeGenCXX/c-linkage.cpp')
-rw-r--r-- | clang/test/CodeGenCXX/c-linkage.cpp | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/clang/test/CodeGenCXX/c-linkage.cpp b/clang/test/CodeGenCXX/c-linkage.cpp index cec9e282f69..f6e64d9e741 100644 --- a/clang/test/CodeGenCXX/c-linkage.cpp +++ b/clang/test/CodeGenCXX/c-linkage.cpp @@ -15,11 +15,13 @@ extern "C" { extern "C" { static void test2_f() { } - // This is not required by the standard, but users assume they know - // the mangling of static functions in extern "C" contexts. - // CHECK: define internal void @test2_f( + // CHECK: define internal void @_Z7test2_fv + static void test2_f(int x) { + } + // CHECK: define internal void @_Z7test2_fi void test2_use() { test2_f(); + test2_f(42); } } |