diff options
author | Ilya Biryukov <ibiryukov@google.com> | 2018-04-24 13:48:53 +0000 |
---|---|---|
committer | Ilya Biryukov <ibiryukov@google.com> | 2018-04-24 13:48:53 +0000 |
commit | b3510c4254fb912045f1ded84df255d20ac0a1d1 (patch) | |
tree | 9cffc4ff55206e6cc65a3f0a4cdea0144f8f44e6 /clang/test/CodeCompletion/using.cpp | |
parent | d6ceda8451d80ca6a3f624777d06b5a3fccba751 (diff) | |
download | bcm5719-llvm-b3510c4254fb912045f1ded84df255d20ac0a1d1.tar.gz bcm5719-llvm-b3510c4254fb912045f1ded84df255d20ac0a1d1.zip |
[CodeComplete] Fix completion at the end of keywords
Summary:
Make completion behave consistently no matter if it is run at the
start, in the middle or at the end of an identifier that happens to
be a keyword or a macro name. Since completion is often ran on
incomplete identifiers, they may turn into keywords by accident.
For example, we should produce same results for all of these
completion points:
// ^ is completion point.
^class
cla^ss
class^
Previously clang produced different results for the last case (as if
the completion point was after a space: `class ^`).
This change also updates some offsets in tests that (unintentionally?)
relied on the old behavior.
Reviewers: sammccall, bkramer, arphaman, aaron.ballman
Reviewed By: sammccall
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D45887
llvm-svn: 330717
Diffstat (limited to 'clang/test/CodeCompletion/using.cpp')
-rw-r--r-- | clang/test/CodeCompletion/using.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/clang/test/CodeCompletion/using.cpp b/clang/test/CodeCompletion/using.cpp index 13ebb4b2d8d..aaad8c976b8 100644 --- a/clang/test/CodeCompletion/using.cpp +++ b/clang/test/CodeCompletion/using.cpp @@ -13,8 +13,8 @@ namespace N2 { void foo() { int N3; - using - // RUN: %clang_cc1 -fsyntax-only -code-completion-at=%s:16:10 %s -o - | FileCheck -check-prefix=CHECK-CC1 %s + using + // RUN: %clang_cc1 -fsyntax-only -code-completion-at=%s:16:11 %s -o - | FileCheck -check-prefix=CHECK-CC1 %s // CHECK-CC1: I1 // CHECK-CC1: I4 // CHECK-CC1: I5 |