summaryrefslogtreecommitdiffstats
path: root/clang/test/CXX/class.derived/class.virtual/p3-0x.cpp
diff options
context:
space:
mode:
authorAlexander Potapenko <glider@google.com>2014-10-03 09:02:53 +0000
committerAlexander Potapenko <glider@google.com>2014-10-03 09:02:53 +0000
commite2e8b0e009a9905b523e1d8bc30c1488fae2f6d7 (patch)
tree2dc6d01171f9646ef044065c9ba0a03a98318616 /clang/test/CXX/class.derived/class.virtual/p3-0x.cpp
parent0b9109c8036c1bfdd91321ae8a8dba3ee41ea7d6 (diff)
downloadbcm5719-llvm-e2e8b0e009a9905b523e1d8bc30c1488fae2f6d7.tar.gz
bcm5719-llvm-e2e8b0e009a9905b523e1d8bc30c1488fae2f6d7.zip
Revert r218925 - "Patch to warn if 'override' is missing"
This CL has caused bootstrap failures on Linux and OSX buildbots running with -Werror. Example report from http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/13183/steps/bootstrap%20clang/logs/stdio: ================================================================ [ 91%] Building CXX object tools/clang/tools/diagtool/CMakeFiles/diagtool.dir/ShowEnabledWarnings.cpp.o In file included from /home/dtoolsbot/build/sanitizer-x86_64-linux/build/llvm/lib/Target/R600/AMDGPUISelDAGToDAG.cpp:20: In file included from /home/dtoolsbot/build/sanitizer-x86_64-linux/build/llvm/lib/Target/R600/SIISelLowering.h:19: /home/dtoolsbot/build/sanitizer-x86_64-linux/build/llvm/lib/Target/R600/SIInstrInfo.h:71:8: error: 'getLdStBaseRegImmOfs' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override] bool getLdStBaseRegImmOfs(MachineInstr *LdSt, ^ /home/dtoolsbot/build/sanitizer-x86_64-linux/build/llvm/include/llvm/Target/TargetInstrInfo.h:815:16: note: overridden virtual function is here virtual bool getLdStBaseRegImmOfs(MachineInstr *LdSt, ^ ================================================================ llvm-svn: 218969
Diffstat (limited to 'clang/test/CXX/class.derived/class.virtual/p3-0x.cpp')
-rw-r--r--clang/test/CXX/class.derived/class.virtual/p3-0x.cpp8
1 files changed, 4 insertions, 4 deletions
diff --git a/clang/test/CXX/class.derived/class.virtual/p3-0x.cpp b/clang/test/CXX/class.derived/class.virtual/p3-0x.cpp
index e3e4dd2877d..41a5954bf86 100644
--- a/clang/test/CXX/class.derived/class.virtual/p3-0x.cpp
+++ b/clang/test/CXX/class.derived/class.virtual/p3-0x.cpp
@@ -61,7 +61,7 @@ struct D : B {
namespace PR13499 {
struct X {
virtual void f();
- virtual void h(); // expected-note 2 {{overridden virtual function is here}}
+ virtual void h();
};
template<typename T> struct A : X {
void f() override;
@@ -83,7 +83,7 @@ namespace PR13499 {
template<typename...T> struct E : X {
void f(T...) override;
void g(T...) override; // expected-error {{only virtual member functions can be marked 'override'}}
- void h(T...) final; // expected-warning {{'h' overrides a member function but is not marked 'override'}}
+ void h(T...) final;
void i(T...) final; // expected-error {{only virtual member functions can be marked 'final'}}
};
// FIXME: Diagnose these in the template definition, not in the instantiation.
@@ -91,13 +91,13 @@ namespace PR13499 {
template<typename T> struct Y : T {
void f() override;
- void h() final; // expected-warning {{'h' overrides a member function but is not marked 'override'}}
+ void h() final;
};
template<typename T> struct Z : T {
void g() override; // expected-error {{only virtual member functions can be marked 'override'}}
void i() final; // expected-error {{only virtual member functions can be marked 'final'}}
};
- Y<X> y; // expected-note {{in instantiation of}}
+ Y<X> y;
Z<X> z; // expected-note {{in instantiation of}}
}
OpenPOWER on IntegriCloud