summaryrefslogtreecommitdiffstats
path: root/clang/test/Analysis/objc_invalidation.m
diff options
context:
space:
mode:
authorAnna Zaks <ganna@apple.com>2012-09-27 19:45:08 +0000
committerAnna Zaks <ganna@apple.com>2012-09-27 19:45:08 +0000
commit8c0dd36ede967f55a6be98ee15253d6bbda28f3b (patch)
tree03afbd64b26e1405b18b26377016f7cf0d2425d2 /clang/test/Analysis/objc_invalidation.m
parenta9183eda74085de82e7c9ad1d2933a60b8ffae43 (diff)
downloadbcm5719-llvm-8c0dd36ede967f55a6be98ee15253d6bbda28f3b.tar.gz
bcm5719-llvm-8c0dd36ede967f55a6be98ee15253d6bbda28f3b.zip
[analyzer] Address Jordan's code review comments for r164716.
llvm-svn: 164788
Diffstat (limited to 'clang/test/Analysis/objc_invalidation.m')
-rw-r--r--clang/test/Analysis/objc_invalidation.m15
1 files changed, 9 insertions, 6 deletions
diff --git a/clang/test/Analysis/objc_invalidation.m b/clang/test/Analysis/objc_invalidation.m
index 7050fdd1757..e0ce28b919c 100644
--- a/clang/test/Analysis/objc_invalidation.m
+++ b/clang/test/Analysis/objc_invalidation.m
@@ -42,15 +42,15 @@
@end
@interface SomeSubclassInvalidatableObject : SomeInvalidationImplementingObject {
- SomeInvalidationImplementingObject *Obj1; // expected-warning{{Ivar needs to be invalidated}}
- SomeInvalidationImplementingObject *Obj2; // expected-warning{{Ivar needs to be invalidated}}
+ SomeInvalidationImplementingObject *Obj1;
+ SomeInvalidationImplementingObject *Obj2;
SomeInvalidationImplementingObject *Obj3;
SomeInvalidationImplementingObject *_Prop1;
SomeInvalidationImplementingObject *_Prop4;
SomeInvalidationImplementingObject *_propIvar;
- Invalidation1Class *MultipleProtocols; // expected-warning{{Ivar needs to be invalidated}}
- Invalidation2Class *MultInheritance; // expected-warning{{Ivar needs to be invalidated}}
-
+ Invalidation1Class *MultipleProtocols;
+ Invalidation2Class *MultInheritance;
+
// No warnings on these.
NSObject *NObj1;
NSObject *NObj2;
@@ -103,5 +103,8 @@
[self setProp3:0];
self.Prop4 = 0;
[super invalidate];
-}
+}// expected-warning {{Instance variable Obj1 needs to be invalidated}}
+ // expected-warning@-1 {{Instance variable Obj2 needs to be invalidated}}
+ // expected-warning@-2 {{Instance variable MultipleProtocols needs to be invalidated}}
+ // expected-warning@-3 {{Instance variable MultInheritance needs to be invalidated}}
@end
OpenPOWER on IntegriCloud