diff options
| author | Volodymyr Sapsai <vsapsai@apple.com> | 2019-02-08 23:02:13 +0000 |
|---|---|---|
| committer | Volodymyr Sapsai <vsapsai@apple.com> | 2019-02-08 23:02:13 +0000 |
| commit | 1570571ded26df0cc0853eecbf1344e56585c2dc (patch) | |
| tree | cc867959303b2686e190251c12faa467006429d5 /clang/test/Analysis/cstring-syntax.c | |
| parent | 114cfafe0585edbdcffbfab2cb32d206f5f02ac7 (diff) | |
| download | bcm5719-llvm-1570571ded26df0cc0853eecbf1344e56585c2dc.tar.gz bcm5719-llvm-1570571ded26df0cc0853eecbf1344e56585c2dc.zip | |
[CodeGen][ObjC] Fix assert on calling `__builtin_constant_p` with ObjC objects.
When we are calling `__builtin_constant_p` with ObjC objects of
different classes, we hit the assertion
> Assertion failed: (isa<X>(Val) && "cast<Ty>() argument of incompatible type!"), function cast, file include/llvm/Support/Casting.h, line 254.
It happens because LLVM types for `ObjCInterfaceType` are opaque and
have no name (see `CodeGenTypes::ConvertType`). As the result, for
different ObjC classes we have different `is_constant` intrinsics with
the same name `llvm.is.constant.p0s_s`. When we try to reuse an
intrinsic with the same name, we fail because of type mismatch.
Fix by bitcasting `ObjCObjectPointerType` to `id` prior to passing as an
argument to `__builtin_constant_p`. This results in using intrinsic
`llvm.is.constant.p0i8` and correct types.
rdar://problem/47499250
Reviewers: rjmccall, ahatanak, void
Reviewed By: void, ahatanak
Subscribers: ddunbar, jkorous, hans, dexonsmith, cfe-commits
Differential Revision: https://reviews.llvm.org/D57427
llvm-svn: 353577
Diffstat (limited to 'clang/test/Analysis/cstring-syntax.c')
0 files changed, 0 insertions, 0 deletions
