diff options
author | George Karpenkov <ekarpenkov@apple.com> | 2019-01-10 18:15:44 +0000 |
---|---|---|
committer | George Karpenkov <ekarpenkov@apple.com> | 2019-01-10 18:15:44 +0000 |
commit | 363dd8e4b86cab350999afbbaf23c5f8fa472b47 (patch) | |
tree | dd810851f8f23424010ff85a20031c1aed869442 /clang/test/Analysis/conditional-path-notes.c | |
parent | 7bac331b7e94735566c9b001adf7f1898c573a38 (diff) | |
download | bcm5719-llvm-363dd8e4b86cab350999afbbaf23c5f8fa472b47.tar.gz bcm5719-llvm-363dd8e4b86cab350999afbbaf23c5f8fa472b47.zip |
[analyzer] [NFC] Reverse the argument order for "diff" in tests
The current argument order has "expected" and "actual" the wrong way around,
so that the diff shows the change from expected to actual, not from actual to expected.
Namely, if the expected diagnostics contains the string "foo", but the analyzer emits "bar",
we really want to see:
```
- foo
+ bar
```
not
```
- bar
+ foo
```
since adapting to most changes would require applying that diff to the expected output.
Differential Revision: https://reviews.llvm.org/D56340
llvm-svn: 350866
Diffstat (limited to 'clang/test/Analysis/conditional-path-notes.c')
-rw-r--r-- | clang/test/Analysis/conditional-path-notes.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/clang/test/Analysis/conditional-path-notes.c b/clang/test/Analysis/conditional-path-notes.c index 77744e39989..fb2dd9f2ca5 100644 --- a/clang/test/Analysis/conditional-path-notes.c +++ b/clang/test/Analysis/conditional-path-notes.c @@ -1,6 +1,6 @@ // RUN: %clang_analyze_cc1 %s -analyzer-checker=core.NullDereference -analyzer-output=text -verify // RUN: %clang_analyze_cc1 %s -analyzer-checker=core.NullDereference -analyzer-output=plist -o %t -// RUN: cat %t | %diff_plist %S/Inputs/expected-plists/conditional-path-notes.c.plist +// RUN: cat %t | %diff_plist %S/Inputs/expected-plists/conditional-path-notes.c.plist - void testCondOp(int *p) { int *x = p ? p : p; |