diff options
| author | Sean Callanan <scallanan@apple.com> | 2016-11-16 18:21:00 +0000 |
|---|---|---|
| committer | Sean Callanan <scallanan@apple.com> | 2016-11-16 18:21:00 +0000 |
| commit | ee6d3fa07eed0d3187ded0cbc63fdbbdc4a8480c (patch) | |
| tree | 6578eb05e2f5031c7d30586ea47f019c2483942d /clang/test/ASTMerge/property/Inputs | |
| parent | 7de9969bb0853f3331a29825ae5a959515d59d87 (diff) | |
| download | bcm5719-llvm-ee6d3fa07eed0d3187ded0cbc63fdbbdc4a8480c.tar.gz bcm5719-llvm-ee6d3fa07eed0d3187ded0cbc63fdbbdc4a8480c.zip | |
Fixed layout of test/ASTMerge.
As outlined in a previous RFC, the test/ASTMerge/Inputs folder is getting full and the tests are starting to become interdependent. This is undesirable because
- it makes it harder to write new tests
- it makes it harder to figure out at a glance what old tests are doing, and
- it adds the risk of breaking one test while changing a different one, because of the interdependencies.
To fix this, according to the conversation in the RFC, I have changed the layout from
a.c
Inputs/a1.c
Inputs/a2.c
to
a/test.c
a/Inputs/a1.c
a/Inputs/a2.c
for all existing tests. I have also eliminated interdependencies by replicating the input files for each test that uses them.
https://reviews.llvm.org/D26571
llvm-svn: 287129
Diffstat (limited to 'clang/test/ASTMerge/property/Inputs')
| -rw-r--r-- | clang/test/ASTMerge/property/Inputs/property1.m | 31 | ||||
| -rw-r--r-- | clang/test/ASTMerge/property/Inputs/property2.m | 33 |
2 files changed, 64 insertions, 0 deletions
diff --git a/clang/test/ASTMerge/property/Inputs/property1.m b/clang/test/ASTMerge/property/Inputs/property1.m new file mode 100644 index 00000000000..22fe0a02220 --- /dev/null +++ b/clang/test/ASTMerge/property/Inputs/property1.m @@ -0,0 +1,31 @@ +// Matching properties +@interface I1 { +} +- (int)getProp2; +- (void)setProp2:(int)value; +@end + +// Mismatched property +@interface I2 +@property (readonly) float Prop1; +@end + +// Properties with implementations +@interface I3 { + int ivar1; + int ivar2; + int ivar3; + int Prop4; +} +@property int Prop1; +@property int Prop2; +@property int Prop3; +@property int Prop4; +@end + +@implementation I3 +@synthesize Prop1 = ivar1; +@synthesize Prop2 = ivar3; +@dynamic Prop3; +@synthesize Prop4; +@end diff --git a/clang/test/ASTMerge/property/Inputs/property2.m b/clang/test/ASTMerge/property/Inputs/property2.m new file mode 100644 index 00000000000..64a03fb04ec --- /dev/null +++ b/clang/test/ASTMerge/property/Inputs/property2.m @@ -0,0 +1,33 @@ +// Matching properties +@interface I1 { +} +- (int)getProp2; +- (void)setProp2:(int)value; +@property (readonly) int Prop1; +@property (getter = getProp2, setter = setProp2:) int Prop2; +@end + +// Mismatched property +@interface I2 +@property (readonly) int Prop1; +@end + +// Properties with implementations +@interface I3 { + int ivar1; + int ivar2; + int ivar3; + int Prop4; +} +@property int Prop1; +@property int Prop2; +@property int Prop3; +@property int Prop4; +@end + +@implementation I3 +@synthesize Prop2 = ivar2; +@synthesize Prop1 = ivar1; +@synthesize Prop3 = ivar3; +@synthesize Prop4 = Prop4; +@end |

