diff options
author | Sean Callanan <scallanan@apple.com> | 2016-11-16 18:21:00 +0000 |
---|---|---|
committer | Sean Callanan <scallanan@apple.com> | 2016-11-16 18:21:00 +0000 |
commit | ee6d3fa07eed0d3187ded0cbc63fdbbdc4a8480c (patch) | |
tree | 6578eb05e2f5031c7d30586ea47f019c2483942d /clang/test/ASTMerge/function | |
parent | 7de9969bb0853f3331a29825ae5a959515d59d87 (diff) | |
download | bcm5719-llvm-ee6d3fa07eed0d3187ded0cbc63fdbbdc4a8480c.tar.gz bcm5719-llvm-ee6d3fa07eed0d3187ded0cbc63fdbbdc4a8480c.zip |
Fixed layout of test/ASTMerge.
As outlined in a previous RFC, the test/ASTMerge/Inputs folder is getting full and the tests are starting to become interdependent. This is undesirable because
- it makes it harder to write new tests
- it makes it harder to figure out at a glance what old tests are doing, and
- it adds the risk of breaking one test while changing a different one, because of the interdependencies.
To fix this, according to the conversation in the RFC, I have changed the layout from
a.c
Inputs/a1.c
Inputs/a2.c
to
a/test.c
a/Inputs/a1.c
a/Inputs/a2.c
for all existing tests. I have also eliminated interdependencies by replicating the input files for each test that uses them.
https://reviews.llvm.org/D26571
llvm-svn: 287129
Diffstat (limited to 'clang/test/ASTMerge/function')
-rw-r--r-- | clang/test/ASTMerge/function/Inputs/function1.c | 6 | ||||
-rw-r--r-- | clang/test/ASTMerge/function/Inputs/function2.c | 7 | ||||
-rw-r--r-- | clang/test/ASTMerge/function/test.c | 15 |
3 files changed, 28 insertions, 0 deletions
diff --git a/clang/test/ASTMerge/function/Inputs/function1.c b/clang/test/ASTMerge/function/Inputs/function1.c new file mode 100644 index 00000000000..4523bd3d79b --- /dev/null +++ b/clang/test/ASTMerge/function/Inputs/function1.c @@ -0,0 +1,6 @@ +void f0(int); +void f1(int, float); +void f2(); +void f3(void); +void f4(int, int); +int f5(int) __attribute__((const)); diff --git a/clang/test/ASTMerge/function/Inputs/function2.c b/clang/test/ASTMerge/function/Inputs/function2.c new file mode 100644 index 00000000000..6ca810a6f20 --- /dev/null +++ b/clang/test/ASTMerge/function/Inputs/function2.c @@ -0,0 +1,7 @@ +typedef int Int; +void f0(Int); +void f1(Int, double); +void f2(int, int); +void f3(int); +static void f4(float, float); +int f5(int) __attribute__((const)); diff --git a/clang/test/ASTMerge/function/test.c b/clang/test/ASTMerge/function/test.c new file mode 100644 index 00000000000..650f719d1fa --- /dev/null +++ b/clang/test/ASTMerge/function/test.c @@ -0,0 +1,15 @@ +// RUN: %clang_cc1 -emit-pch -o %t.1.ast %S/Inputs/function1.c +// RUN: %clang_cc1 -emit-pch -o %t.2.ast %S/Inputs/function2.c +// RUN: not %clang_cc1 -ast-merge %t.1.ast -ast-merge %t.2.ast -fsyntax-only %s 2>&1 | FileCheck %s +// RUN: %clang_cc1 -ast-merge %t.1.ast -ast-merge %t.2.ast -fsyntax-only -verify %s + +// CHECK: function2.c:3:6: error: external function 'f1' declared with incompatible types in different translation units ('void (Int, double)' (aka 'void (int, double)') vs. 'void (int, float)') +// CHECK: function1.c:2:6: note: declared here with type 'void (int, float)' +// CHECK: function2.c:5:6: error: external function 'f3' declared with incompatible types in different translation units ('void (int)' vs. 'void (void)') +// CHECK: function1.c:4:6: note: declared here with type 'void (void)' +// CHECK: 2 errors generated + +// expected-error@Inputs/function2.c:3 {{external function 'f1' declared with incompatible types}} +// expected-note@Inputs/function1.c:2 {{declared here}} +// expected-error@Inputs/function2.c:5 {{external function 'f3' declared with incompatible types}} +// expected-note@Inputs/function1.c:4 {{declared here}} |