summaryrefslogtreecommitdiffstats
path: root/clang/lib
diff options
context:
space:
mode:
authorRichard Smith <richard-llvm@metafoo.co.uk>2018-10-09 18:49:22 +0000
committerRichard Smith <richard-llvm@metafoo.co.uk>2018-10-09 18:49:22 +0000
commite54d9525ad594a0084f003244ad56982c412c4b0 (patch)
tree6f9f9c0089d94dc180aba94f5a8f1cf142ffc4ba /clang/lib
parent81abca32fba4d8eb537c4ac4445e0175309b9fc8 (diff)
downloadbcm5719-llvm-e54d9525ad594a0084f003244ad56982c412c4b0.tar.gz
bcm5719-llvm-e54d9525ad594a0084f003244ad56982c412c4b0.zip
PR39231: fix null dereference when diagnosing deduction failure due to
conflicting values for a non-type pack. llvm-svn: 344070
Diffstat (limited to 'clang/lib')
-rw-r--r--clang/lib/Sema/SemaOverload.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/clang/lib/Sema/SemaOverload.cpp b/clang/lib/Sema/SemaOverload.cpp
index f4ec04a1b29..a5a51d54830 100644
--- a/clang/lib/Sema/SemaOverload.cpp
+++ b/clang/lib/Sema/SemaOverload.cpp
@@ -9984,7 +9984,7 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl *Found, Decl *Templated,
DeductionFailure.getFirstArg()->getNonTypeTemplateArgumentType();
QualType T2 =
DeductionFailure.getSecondArg()->getNonTypeTemplateArgumentType();
- if (!S.Context.hasSameType(T1, T2)) {
+ if (!T1.isNull() && !T2.isNull() && !S.Context.hasSameType(T1, T2)) {
S.Diag(Templated->getLocation(),
diag::note_ovl_candidate_inconsistent_deduction_types)
<< ParamD->getDeclName() << *DeductionFailure.getFirstArg() << T1
OpenPOWER on IntegriCloud