diff options
| author | Richard Trieu <rtrieu@google.com> | 2013-04-18 01:04:37 +0000 |
|---|---|---|
| committer | Richard Trieu <rtrieu@google.com> | 2013-04-18 01:04:37 +0000 |
| commit | e089497121ddbcbed3131ee2e064c7434164dc46 (patch) | |
| tree | 69e8f7dc65a16d06ae7f53a6900751e996476db7 /clang/lib | |
| parent | 89af58991a007bdebd1450c499c888bce93d84f2 (diff) | |
| download | bcm5719-llvm-e089497121ddbcbed3131ee2e064c7434164dc46.tar.gz bcm5719-llvm-e089497121ddbcbed3131ee2e064c7434164dc46.zip | |
Switch the note order for -Woverloaded-shift-op-parentheses so that the note
with the silence fix-it comes first. This is more consistent with the rest
of the warnings in -Wparentheses.
llvm-svn: 179742
Diffstat (limited to 'clang/lib')
| -rw-r--r-- | clang/lib/Sema/SemaExpr.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/clang/lib/Sema/SemaExpr.cpp b/clang/lib/Sema/SemaExpr.cpp index ce60f9171fd..fb0e9ef687c 100644 --- a/clang/lib/Sema/SemaExpr.cpp +++ b/clang/lib/Sema/SemaExpr.cpp @@ -8894,14 +8894,14 @@ static void DiagnoseShiftCompare(Sema &S, SourceLocation OpLoc, S.Diag(OpLoc, diag::warn_overloaded_shift_in_comparison) << LHSExpr->getSourceRange() << RHSExpr->getSourceRange() << (Kind == OO_LessLess); - SuggestParentheses(S, OpLoc, - S.PDiag(diag::note_evaluate_comparison_first), - SourceRange(OCE->getArg(1)->getLocStart(), - RHSExpr->getLocEnd())); SuggestParentheses(S, OCE->getOperatorLoc(), S.PDiag(diag::note_precedence_silence) << (Kind == OO_LessLess ? "<<" : ">>"), OCE->getSourceRange()); + SuggestParentheses(S, OpLoc, + S.PDiag(diag::note_evaluate_comparison_first), + SourceRange(OCE->getArg(1)->getLocStart(), + RHSExpr->getLocEnd())); } /// DiagnoseBinOpPrecedence - Emit warnings for expressions with tricky |
