summaryrefslogtreecommitdiffstats
path: root/clang/lib
diff options
context:
space:
mode:
authorRafael Espindola <rafael.espindola@gmail.com>2014-12-17 23:49:22 +0000
committerRafael Espindola <rafael.espindola@gmail.com>2014-12-17 23:49:22 +0000
commitd1cdcb237713946e964c8de18759752697494227 (patch)
tree1cb71c7cb744b777d425d44869ab0fd7183509e6 /clang/lib
parentae23ffb751484450d55e9c6d7d464046ce3194b0 (diff)
downloadbcm5719-llvm-d1cdcb237713946e964c8de18759752697494227.tar.gz
bcm5719-llvm-d1cdcb237713946e964c8de18759752697494227.zip
Revert "Put static local variables of inline functions in the function comdat."
This reverts commit r224369. Thanks to Reid Kleckner for pointing out that we need a bigger gun to fix this case. llvm-svn: 224475
Diffstat (limited to 'clang/lib')
-rw-r--r--clang/lib/CodeGen/ItaniumCXXABI.cpp6
1 files changed, 2 insertions, 4 deletions
diff --git a/clang/lib/CodeGen/ItaniumCXXABI.cpp b/clang/lib/CodeGen/ItaniumCXXABI.cpp
index 8d74faf1797..fd299d14c13 100644
--- a/clang/lib/CodeGen/ItaniumCXXABI.cpp
+++ b/clang/lib/CodeGen/ItaniumCXXABI.cpp
@@ -1711,10 +1711,8 @@ void ItaniumCXXABI::EmitGuardedInit(CodeGenFunction &CGF,
// The ABI says: It is suggested that it be emitted in the same COMDAT group
// as the associated data object
- if (var->isWeakForLinker() && CGM.supportsCOMDAT()) {
- StringRef ComdatName =
- D.isLocalVarDecl() ? CGF.CurFn->getName() : var->getName();
- llvm::Comdat *C = CGM.getModule().getOrInsertComdat(ComdatName);
+ if (!D.isLocalVarDecl() && var->isWeakForLinker() && CGM.supportsCOMDAT()) {
+ llvm::Comdat *C = CGM.getModule().getOrInsertComdat(var->getName());
guard->setComdat(C);
var->setComdat(C);
CGF.CurFn->setComdat(C);
OpenPOWER on IntegriCloud