diff options
| author | John McCall <rjmccall@apple.com> | 2010-04-22 18:44:12 +0000 |
|---|---|---|
| committer | John McCall <rjmccall@apple.com> | 2010-04-22 18:44:12 +0000 |
| commit | 8c12dc4351be21ba2472abdbd985f99b4847eabd (patch) | |
| tree | fedc5fc29feae23c0ab2b08b5eaf8d64901d2cb4 /clang/lib | |
| parent | 0fde4aeedd9401444f38103b363704864f9d1617 (diff) | |
| download | bcm5719-llvm-8c12dc4351be21ba2472abdbd985f99b4847eabd.tar.gz bcm5719-llvm-8c12dc4351be21ba2472abdbd985f99b4847eabd.zip | |
Use the naming class from the overloaded lookup when access-checking an
address of overloaded function, instead of assuming that a nested name
specifier was used. A nested name specifier is not required for static
functions.
Fixes PR6886.
llvm-svn: 102107
Diffstat (limited to 'clang/lib')
| -rw-r--r-- | clang/lib/AST/ExprCXX.cpp | 7 | ||||
| -rw-r--r-- | clang/lib/Sema/SemaAccess.cpp | 10 |
2 files changed, 8 insertions, 9 deletions
diff --git a/clang/lib/AST/ExprCXX.cpp b/clang/lib/AST/ExprCXX.cpp index b9a4ee6e4d2..c19fd834eae 100644 --- a/clang/lib/AST/ExprCXX.cpp +++ b/clang/lib/AST/ExprCXX.cpp @@ -180,6 +180,13 @@ bool OverloadExpr::ComputeDependence(UnresolvedSetIterator Begin, return false; } +CXXRecordDecl *OverloadExpr::getNamingClass() const { + if (isa<UnresolvedLookupExpr>(this)) + return cast<UnresolvedLookupExpr>(this)->getNamingClass(); + else + return cast<UnresolvedMemberExpr>(this)->getNamingClass(); +} + Stmt::child_iterator UnresolvedLookupExpr::child_begin() { return child_iterator(); } diff --git a/clang/lib/Sema/SemaAccess.cpp b/clang/lib/Sema/SemaAccess.cpp index af0c5b526ce..14a693f5b64 100644 --- a/clang/lib/Sema/SemaAccess.cpp +++ b/clang/lib/Sema/SemaAccess.cpp @@ -1230,15 +1230,7 @@ Sema::AccessResult Sema::CheckAddressOfMemberAccess(Expr *OvlExpr, return AR_accessible; OverloadExpr *Ovl = OverloadExpr::find(OvlExpr).getPointer(); - NestedNameSpecifier *Qualifier = Ovl->getQualifier(); - assert(Qualifier && "address of overloaded member without qualifier"); - - CXXScopeSpec SS; - SS.setScopeRep(Qualifier); - SS.setRange(Ovl->getQualifierRange()); - DeclContext *DC = computeDeclContext(SS); - assert(DC && DC->isRecord() && "scope did not resolve to record"); - CXXRecordDecl *NamingClass = cast<CXXRecordDecl>(DC); + CXXRecordDecl *NamingClass = Ovl->getNamingClass(); AccessTarget Entity(Context, AccessTarget::Member, NamingClass, Found, Context.getTypeDeclType(NamingClass)); |

