diff options
| author | Benjamin Kramer <benny.kra@googlemail.com> | 2010-01-30 15:01:47 +0000 |
|---|---|---|
| committer | Benjamin Kramer <benny.kra@googlemail.com> | 2010-01-30 15:01:47 +0000 |
| commit | 842bf1736671be31378c445422662f267d366426 (patch) | |
| tree | 7fd79d2b5aba33c0dc0105dd5c41d51c293479e8 /clang/lib | |
| parent | 25df248382fb4cca50f2a28aeee760c0787da617 (diff) | |
| download | bcm5719-llvm-842bf1736671be31378c445422662f267d366426.tar.gz bcm5719-llvm-842bf1736671be31378c445422662f267d366426.zip | |
Use StringRef instead of returning a temporary std::string.
This fixes a really nasty bug in Darwin::getDarwinArchName where we were going
StringRef -> temporary std::string -> StringRef (and return the dead StringRef).
The StringRefs from Triple live as long as the Triple itself, that should be
long enough.
Hopefully 2 of 4 MSVC buildbot failures are gone now.
llvm-svn: 94892
Diffstat (limited to 'clang/lib')
| -rw-r--r-- | clang/lib/Driver/Tools.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/clang/lib/Driver/Tools.cpp b/clang/lib/Driver/Tools.cpp index 2e7435fa32a..2354bd494e6 100644 --- a/clang/lib/Driver/Tools.cpp +++ b/clang/lib/Driver/Tools.cpp @@ -512,7 +512,7 @@ void Clang::AddX86TargetArgs(const ArgList &Args, // Select the default CPU if none was given (or detection failed). if (!CPUName) { // FIXME: Need target hooks. - if (memcmp(getToolChain().getOS().c_str(), "darwin", 6) == 0) { + if (getToolChain().getOS().startswith("darwin")) { if (getToolChain().getArchName() == "x86_64") CPUName = "core2"; else if (getToolChain().getArchName() == "i386") |
