diff options
| author | Fariborz Jahanian <fjahanian@apple.com> | 2011-02-08 22:33:23 +0000 |
|---|---|---|
| committer | Fariborz Jahanian <fjahanian@apple.com> | 2011-02-08 22:33:23 +0000 |
| commit | 701f094afb93444a8f71f720390b8cca56ad82e6 (patch) | |
| tree | 2e71c4b5e59d6052111eaa7132165eec4aceb83a /clang/lib | |
| parent | fa0734ec4f15f8a83053812e17e210f5790c042a (diff) | |
| download | bcm5719-llvm-701f094afb93444a8f71f720390b8cca56ad82e6.tar.gz bcm5719-llvm-701f094afb93444a8f71f720390b8cca56ad82e6.zip | |
Fix an IRGen bug in property setter calls when
setter and getter types mismatch. // rdar://8966864
llvm-svn: 125125
Diffstat (limited to 'clang/lib')
| -rw-r--r-- | clang/lib/CodeGen/CGObjC.cpp | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/clang/lib/CodeGen/CGObjC.cpp b/clang/lib/CodeGen/CGObjC.cpp index 1c64e3cb4c3..066ae5ab3ac 100644 --- a/clang/lib/CodeGen/CGObjC.cpp +++ b/clang/lib/CodeGen/CGObjC.cpp @@ -585,7 +585,17 @@ void CodeGenFunction::EmitStoreThroughPropertyRefLValue(RValue Src, } else { ArgType = E->getType(); } - + // FIXME. Other than scalars, AST is not adequate for setter and + // getter type mismatches which require conversion. + if (Src.isScalar()) { + llvm::Value *SrcVal = Src.getScalarVal(); + QualType DstType = getContext().getCanonicalType(ArgType); + const llvm::Type *DstTy = ConvertType(DstType); + if (SrcVal->getType() != DstTy) + Src = + RValue::get(EmitScalarConversion(SrcVal, E->getType(), DstType)); + } + CallArgList Args; Args.push_back(std::make_pair(Src, ArgType)); |

