diff options
author | Alexandre Ganea <alexandre.ganea@ubisoft.com> | 2020-01-21 17:03:00 -0500 |
---|---|---|
committer | Hans Wennborg <hans@chromium.org> | 2020-01-22 18:29:36 +0100 |
commit | 54acc20e6da529f8ab6183d912a75a94b25d2bd9 (patch) | |
tree | 7741f42e4c0ddcdbade42ec1706cf4577012788e /clang/lib | |
parent | 3cce3790072249cbe51b96cea26bc78019c11fd0 (diff) | |
download | bcm5719-llvm-54acc20e6da529f8ab6183d912a75a94b25d2bd9.tar.gz bcm5719-llvm-54acc20e6da529f8ab6183d912a75a94b25d2bd9.zip |
[PATCH] Reland [Clang] Un-break scan-build after integrated-cc1 change
The issue was reported by @xazax.hun here: https://reviews.llvm.org/D69825#1827826
"This patch (D69825) breaks scan-build-py which parses the output of "-###" to get -cc1 command. There might be other tools with the same problems. Could we either remove (in-process) from CC1Command::Print or add a line break?
Having the last line as a valid invocation is valuable and there might be tools relying on that."
Differential Revision: https://reviews.llvm.org/D72982
(cherry picked from commit 133a7e631cee97965e310f0d110739217427fd3d)
Diffstat (limited to 'clang/lib')
-rw-r--r-- | clang/lib/Driver/Compilation.cpp | 2 | ||||
-rw-r--r-- | clang/lib/Driver/Job.cpp | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/clang/lib/Driver/Compilation.cpp b/clang/lib/Driver/Compilation.cpp index ba188f5c408..25aec3690f2 100644 --- a/clang/lib/Driver/Compilation.cpp +++ b/clang/lib/Driver/Compilation.cpp @@ -172,7 +172,7 @@ int Compilation::ExecuteCommand(const Command &C, } if (getDriver().CCPrintOptions) - *OS << "[Logging clang options]"; + *OS << "[Logging clang options]\n"; C.Print(*OS, "\n", /*Quote=*/getDriver().CCPrintOptions); } diff --git a/clang/lib/Driver/Job.cpp b/clang/lib/Driver/Job.cpp index d57c3a1cdbb..7dab2a022d9 100644 --- a/clang/lib/Driver/Job.cpp +++ b/clang/lib/Driver/Job.cpp @@ -373,7 +373,7 @@ int Command::Execute(ArrayRef<llvm::Optional<StringRef>> Redirects, void CC1Command::Print(raw_ostream &OS, const char *Terminator, bool Quote, CrashReportInfo *CrashInfo) const { - OS << " (in-process)"; + OS << " (in-process)\n"; Command::Print(OS, Terminator, Quote, CrashInfo); } |