diff options
| author | Benjamin Kramer <benny.kra@googlemail.com> | 2012-10-04 10:06:38 +0000 |
|---|---|---|
| committer | Benjamin Kramer <benny.kra@googlemail.com> | 2012-10-04 10:06:38 +0000 |
| commit | 4f23bee060f6a6582ba4896d8505ee9320f162c4 (patch) | |
| tree | 407ba2a24ca60f2c07708b98c6b3a54f78b45d49 /clang/lib | |
| parent | cd679fda6c193731dcaa85e3322663d52d7b1e3e (diff) | |
| download | bcm5719-llvm-4f23bee060f6a6582ba4896d8505ee9320f162c4.tar.gz bcm5719-llvm-4f23bee060f6a6582ba4896d8505ee9320f162c4.zip | |
Prefer StringRef::startswith to the strncmp/strlen contraption.
This may be slightly more efficient and is definitely more readable.
llvm-svn: 165217
Diffstat (limited to 'clang/lib')
| -rw-r--r-- | clang/lib/Driver/OptTable.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/clang/lib/Driver/OptTable.cpp b/clang/lib/Driver/OptTable.cpp index 257f3537a17..e108106fa7e 100644 --- a/clang/lib/Driver/OptTable.cpp +++ b/clang/lib/Driver/OptTable.cpp @@ -159,10 +159,11 @@ Arg *OptTable::ParseOneArg(const ArgList &Args, unsigned &Index) const { // FIXME: This is searching much more than necessary, but I am // blanking on the simplest way to make it fast. We can solve this // problem when we move to TableGen. + StringRef StrRef(Str); for (; Start != End; ++Start) { // Scan for first option which is a proper prefix. for (; Start != End; ++Start) - if (strncmp(Str, Start->Name, strlen(Start->Name)) == 0) + if (StrRef.startswith(Start->Name)) break; if (Start == End) break; |
