diff options
| author | Eli Friedman <eli.friedman@gmail.com> | 2009-12-11 20:48:18 +0000 |
|---|---|---|
| committer | Eli Friedman <eli.friedman@gmail.com> | 2009-12-11 20:48:18 +0000 |
| commit | 3ace52b3a7aac94bddccb9c0282a914a1d8080b9 (patch) | |
| tree | 468f1ced46e330eb12fedb0aa967f1a0cf00511b /clang/lib | |
| parent | 22a4ea8690352ce82fe754e1550da86f07cf626a (diff) | |
| download | bcm5719-llvm-3ace52b3a7aac94bddccb9c0282a914a1d8080b9.tar.gz bcm5719-llvm-3ace52b3a7aac94bddccb9c0282a914a1d8080b9.zip | |
Fix linkage of type info and vtable for classes without linkage.
llvm-svn: 91152
Diffstat (limited to 'clang/lib')
| -rw-r--r-- | clang/lib/CodeGen/CGRTTI.cpp | 4 | ||||
| -rw-r--r-- | clang/lib/CodeGen/CGVtable.cpp | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/clang/lib/CodeGen/CGRTTI.cpp b/clang/lib/CodeGen/CGRTTI.cpp index a574703935c..a15ba4f2157 100644 --- a/clang/lib/CodeGen/CGRTTI.cpp +++ b/clang/lib/CodeGen/CGRTTI.cpp @@ -230,7 +230,7 @@ public: return llvm::ConstantExpr::getBitCast(GV, Int8PtrTy); // If we're in an anonymous namespace, then we always want internal linkage. - if (RD->isInAnonymousNamespace()) + if (RD->isInAnonymousNamespace() || !RD->hasLinkage()) Linkage = llvm::GlobalVariable::InternalLinkage; bool Hidden = CGM.getDeclVisibilityMode(RD) == LangOptions::Hidden; @@ -295,7 +295,7 @@ public: return DecideExtern(PT->getPointeeType()); if (const RecordType *RT = Ty->getAs<RecordType>()) if (const CXXRecordDecl *RD = dyn_cast<CXXRecordDecl>(RT->getDecl())) - return !RD->isInAnonymousNamespace(); + return !RD->isInAnonymousNamespace() && RD->hasLinkage(); return true; } diff --git a/clang/lib/CodeGen/CGVtable.cpp b/clang/lib/CodeGen/CGVtable.cpp index 752f69c7c29..868a3414408 100644 --- a/clang/lib/CodeGen/CGVtable.cpp +++ b/clang/lib/CodeGen/CGVtable.cpp @@ -1458,7 +1458,7 @@ void CGVtableInfo::MaybeEmitVtable(GlobalDecl GD) { } llvm::GlobalVariable::LinkageTypes Linkage; - if (RD->isInAnonymousNamespace()) + if (RD->isInAnonymousNamespace() || !RD->hasLinkage()) Linkage = llvm::GlobalVariable::InternalLinkage; else if (KeyFunction && !MD->isInlined()) Linkage = llvm::GlobalVariable::ExternalLinkage; |

