summaryrefslogtreecommitdiffstats
path: root/clang/lib
diff options
context:
space:
mode:
authorZachary Turner <zturner@google.com>2017-12-14 22:07:03 +0000
committerZachary Turner <zturner@google.com>2017-12-14 22:07:03 +0000
commit260fe3eca6903f23fd017bafb7e555f4be8acf11 (patch)
treeef63acf019f5de6c362d767ff1fd8165f083f59d /clang/lib
parent0ab0c1a201ece292fdced1f913fa257bdcb5280f (diff)
downloadbcm5719-llvm-260fe3eca6903f23fd017bafb7e555f4be8acf11.tar.gz
bcm5719-llvm-260fe3eca6903f23fd017bafb7e555f4be8acf11.zip
Fix many -Wsign-compare and -Wtautological-constant-compare warnings.
Most of the -Wsign-compare warnings are due to the fact that enums are signed by default in the MS ABI, while the tautological comparison warnings trigger on x86 builds where sizeof(size_t) is 4 bytes, so N > numeric_limits<unsigned>::max() is always false. Differential Revision: https://reviews.llvm.org/D41256 llvm-svn: 320750
Diffstat (limited to 'clang/lib')
-rw-r--r--clang/lib/CodeGen/CGExpr.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/clang/lib/CodeGen/CGExpr.cpp b/clang/lib/CodeGen/CGExpr.cpp
index c61bc0d6422..98740e8f9aa 100644
--- a/clang/lib/CodeGen/CGExpr.cpp
+++ b/clang/lib/CodeGen/CGExpr.cpp
@@ -2825,7 +2825,7 @@ void CodeGenFunction::EmitCheck(
assert(IsSanitizerScope);
assert(Checked.size() > 0);
assert(CheckHandler >= 0 &&
- CheckHandler < sizeof(SanitizerHandlers) / sizeof(*SanitizerHandlers));
+ size_t(CheckHandler) < llvm::array_lengthof(SanitizerHandlers));
const StringRef CheckName = SanitizerHandlers[CheckHandler].Name;
llvm::Value *FatalCond = nullptr;
OpenPOWER on IntegriCloud