summaryrefslogtreecommitdiffstats
path: root/clang/lib
diff options
context:
space:
mode:
authorNick Lewycky <nicholas@mxc.ca>2013-01-10 01:46:29 +0000
committerNick Lewycky <nicholas@mxc.ca>2013-01-10 01:46:29 +0000
commit230203c9499991eb28f8926d0c96fe0b55b82ccb (patch)
treea5b687b495a915d55105247d35c443630862c442 /clang/lib
parent4ddf2221b41ec9fe2cc0c8588f1537be43c81ddb (diff)
downloadbcm5719-llvm-230203c9499991eb28f8926d0c96fe0b55b82ccb.tar.gz
bcm5719-llvm-230203c9499991eb28f8926d0c96fe0b55b82ccb.zip
Don't assert in codegen on static data members which have NoLinkage. Fixes
PR14825! llvm-svn: 172031
Diffstat (limited to 'clang/lib')
-rw-r--r--clang/lib/CodeGen/CGExpr.cpp6
1 files changed, 2 insertions, 4 deletions
diff --git a/clang/lib/CodeGen/CGExpr.cpp b/clang/lib/CodeGen/CGExpr.cpp
index e5f9672b0f8..c002bb1432d 100644
--- a/clang/lib/CodeGen/CGExpr.cpp
+++ b/clang/lib/CodeGen/CGExpr.cpp
@@ -1583,8 +1583,6 @@ EmitBitCastOfLValueToProperType(CodeGenFunction &CGF,
static LValue EmitGlobalVarDeclLValue(CodeGenFunction &CGF,
const Expr *E, const VarDecl *VD) {
- assert(VD->hasLinkage() && "Var decl must have linkage!");
-
llvm::Value *V = CGF.CGM.GetAddrOfGlobalVar(VD);
llvm::Type *RealVarTy = CGF.getTypes().ConvertTypeForMem(VD->getType());
V = EmitBitCastOfLValueToProperType(CGF, V, RealVarTy);
@@ -1657,7 +1655,7 @@ LValue CodeGenFunction::EmitDeclRefLValue(const DeclRefExpr *E) {
if (const VarDecl *VD = dyn_cast<VarDecl>(ND)) {
// Check if this is a global variable.
- if (VD->hasLinkage())
+ if (VD->hasLinkage() || VD->isStaticDataMember())
return EmitGlobalVarDeclLValue(*this, E, VD);
bool isBlockVariable = VD->hasAttr<BlocksAttr>();
@@ -1666,7 +1664,7 @@ LValue CodeGenFunction::EmitDeclRefLValue(const DeclRefExpr *E) {
!VD->getType()->isReferenceType() &&
!isBlockVariable;
- llvm::Value *V = LocalDeclMap[VD];
+ llvm::Value *V = LocalDeclMap.lookup(VD);
if (!V && VD->isStaticLocal())
V = CGM.getStaticLocalDeclAddress(VD);
OpenPOWER on IntegriCloud