diff options
| author | Chandler Carruth <chandlerc@gmail.com> | 2011-10-04 09:58:21 +0000 |
|---|---|---|
| committer | Chandler Carruth <chandlerc@gmail.com> | 2011-10-04 09:58:21 +0000 |
| commit | 1a98ab4fc34ab6b759282d873eb4d5481b6b58cc (patch) | |
| tree | 3f34e05e1f8e39e4a9d28a512c26fd4ec5ec4091 /clang/lib | |
| parent | 1d6073abad74cf9fa562f6e5dbc9a8cabe4fb8b1 (diff) | |
| download | bcm5719-llvm-1a98ab4fc34ab6b759282d873eb4d5481b6b58cc.tar.gz bcm5719-llvm-1a98ab4fc34ab6b759282d873eb4d5481b6b58cc.zip | |
Add a comment explaining that I have a better plan for implementing the
GCC installation search that requires fewer filesystem operations.
Planning to implement that next as the current approcah while thorough
(and so far looks correct) does a very unfortunate number of filesystem
operations.
I'm motivated to fix this in no small part because I would like to
support a much larger space of triples and GCC versions, which would
explode the current algorithm.
llvm-svn: 141073
Diffstat (limited to 'clang/lib')
| -rw-r--r-- | clang/lib/Driver/ToolChains.cpp | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/clang/lib/Driver/ToolChains.cpp b/clang/lib/Driver/ToolChains.cpp index dd84992a9c1..b67f001e78d 100644 --- a/clang/lib/Driver/ToolChains.cpp +++ b/clang/lib/Driver/ToolChains.cpp @@ -1605,6 +1605,8 @@ public: // accuracy, and architecture specificity in that order. The inverted walk // requires testing the filesystem more times than is ideal, but shouldn't // matter in practice as this is once on startup. + // FIXME: Instead of this, we should walk from the root down through each + // layer, and if it is "better" than prior installations found, use it. static const char* GccVersions[] = { "4.6.1", "4.6.0", "4.6", "4.5.3", "4.5.2", "4.5.1", "4.5", |
