diff options
| author | Richard Smith <richard-llvm@metafoo.co.uk> | 2017-10-18 01:41:38 +0000 |
|---|---|---|
| committer | Richard Smith <richard-llvm@metafoo.co.uk> | 2017-10-18 01:41:38 +0000 |
| commit | 17ad3ac2aacf3c38cc60c914736bd71d67eaad83 (patch) | |
| tree | c4e576c27a5d2990959e8171743374cb717e743d /clang/lib | |
| parent | 1fc49627e498eeaedcc79ae301df1adf47592583 (diff) | |
| download | bcm5719-llvm-17ad3ac2aacf3c38cc60c914736bd71d67eaad83.tar.gz bcm5719-llvm-17ad3ac2aacf3c38cc60c914736bd71d67eaad83.zip | |
[modules] When finding the owning module of an instantiated context in template
instantiation, follow lexical parents not semantic ones: we want to find the
module where the pattern was written.
llvm-svn: 316055
Diffstat (limited to 'clang/lib')
| -rw-r--r-- | clang/lib/Frontend/VerifyDiagnosticConsumer.cpp | 13 | ||||
| -rw-r--r-- | clang/lib/Sema/SemaLookup.cpp | 2 |
2 files changed, 11 insertions, 4 deletions
diff --git a/clang/lib/Frontend/VerifyDiagnosticConsumer.cpp b/clang/lib/Frontend/VerifyDiagnosticConsumer.cpp index 427d15ed703..a49c424e915 100644 --- a/clang/lib/Frontend/VerifyDiagnosticConsumer.cpp +++ b/clang/lib/Frontend/VerifyDiagnosticConsumer.cpp @@ -416,9 +416,12 @@ static bool ParseDirective(StringRef S, ExpectedData *ED, SourceManager &SM, MatchAnyLine = true; ExpectedLoc = SM.translateFileLineCol(FE, 1, 1); } + } else if (PH.Next("*")) { + MatchAnyLine = true; + ExpectedLoc = SourceLocation(); } - if (ExpectedLoc.isInvalid()) { + if (ExpectedLoc.isInvalid() && !MatchAnyLine) { Diags.Report(Pos.getLocWithOffset(PH.C-PH.Begin), diag::err_verify_missing_line) << KindStr; continue; @@ -650,7 +653,10 @@ static unsigned PrintExpected(DiagnosticsEngine &Diags, llvm::raw_svector_ostream OS(Fmt); for (auto *DirPtr : DL) { Directive &D = *DirPtr; - OS << "\n File " << SourceMgr.getFilename(D.DiagnosticLoc); + if (D.DiagnosticLoc.isInvalid()) + OS << "\n File *"; + else + OS << "\n File " << SourceMgr.getFilename(D.DiagnosticLoc); if (D.MatchAnyLine) OS << " Line *"; else @@ -708,7 +714,8 @@ static unsigned CheckLists(DiagnosticsEngine &Diags, SourceManager &SourceMgr, continue; } - if (!IsFromSameFile(SourceMgr, D.DiagnosticLoc, II->first)) + if (!D.DiagnosticLoc.isInvalid() && + !IsFromSameFile(SourceMgr, D.DiagnosticLoc, II->first)) continue; const std::string &RightText = II->second; diff --git a/clang/lib/Sema/SemaLookup.cpp b/clang/lib/Sema/SemaLookup.cpp index 827c7012bc3..73aceaaf94c 100644 --- a/clang/lib/Sema/SemaLookup.cpp +++ b/clang/lib/Sema/SemaLookup.cpp @@ -1374,7 +1374,7 @@ static Module *getDefiningModule(Sema &S, Decl *Entity) { // Walk up to the containing context. That might also have been instantiated // from a template. - DeclContext *Context = Entity->getDeclContext(); + DeclContext *Context = Entity->getLexicalDeclContext(); if (Context->isFileContext()) return S.getOwningModule(Entity); return getDefiningModule(S, cast<Decl>(Context)); |

