diff options
| author | Ehsan Akhgari <ehsan.akhgari@gmail.com> | 2014-09-22 19:46:39 +0000 |
|---|---|---|
| committer | Ehsan Akhgari <ehsan.akhgari@gmail.com> | 2014-09-22 19:46:39 +0000 |
| commit | 0b510602ceadccf9ca1e441c1f21d227457e9090 (patch) | |
| tree | 4de38771f0896f1f5b3b935efb967ee50f195e6b /clang/lib | |
| parent | 7dd95610e5b5db178a77ae29e2bee2e26a511eb1 (diff) | |
| download | bcm5719-llvm-0b510602ceadccf9ca1e441c1f21d227457e9090.tar.gz bcm5719-llvm-0b510602ceadccf9ca1e441c1f21d227457e9090.zip | |
Return true from UnifySection when emitting a diagnostic
Test Plan: I noticed this through code inspection. The callers use the return value to remove the SectionAttr if a diagnostic is emitted, but I don't think the failure to do so is observable right now.
Reviewers: rnk
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/D5438
llvm-svn: 218265
Diffstat (limited to 'clang/lib')
| -rw-r--r-- | clang/lib/Sema/SemaAttr.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/clang/lib/Sema/SemaAttr.cpp b/clang/lib/Sema/SemaAttr.cpp index 6320faab374..f92bb68d209 100644 --- a/clang/lib/Sema/SemaAttr.cpp +++ b/clang/lib/Sema/SemaAttr.cpp @@ -384,7 +384,7 @@ bool Sema::UnifySection(StringRef SectionName, if (auto A = OtherDecl->getAttr<SectionAttr>()) if (A->isImplicit()) Diag(A->getLocation(), diag::note_pragma_entered_here); - return false; + return true; } bool Sema::UnifySection(StringRef SectionName, |
