diff options
author | Justin Bogner <mail@justinbogner.com> | 2014-10-03 01:04:53 +0000 |
---|---|---|
committer | Justin Bogner <mail@justinbogner.com> | 2014-10-03 01:04:53 +0000 |
commit | aab9792b6c46b07f4f2caee1778f619387781e0c (patch) | |
tree | c72a7311cfbed171e17167e2cd834d94d2f08287 /clang/lib/Tooling/CompilationDatabase.cpp | |
parent | e83f59e6580e12f1af705ce47425cd954ef1ad7c (diff) | |
download | bcm5719-llvm-aab9792b6c46b07f4f2caee1778f619387781e0c.tar.gz bcm5719-llvm-aab9792b6c46b07f4f2caee1778f619387781e0c.zip |
Driver: Use pointee_iterator rather than iterating over unique_ptrs
There's probably never a good reason to iterate over unique_ptrs. This
lets us use range-for and say Job.foo instead of (*it)->foo in a few
places.
llvm-svn: 218938
Diffstat (limited to 'clang/lib/Tooling/CompilationDatabase.cpp')
-rw-r--r-- | clang/lib/Tooling/CompilationDatabase.cpp | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/clang/lib/Tooling/CompilationDatabase.cpp b/clang/lib/Tooling/CompilationDatabase.cpp index f16f64744e2..7613988c96d 100644 --- a/clang/lib/Tooling/CompilationDatabase.cpp +++ b/clang/lib/Tooling/CompilationDatabase.cpp @@ -249,10 +249,9 @@ static bool stripPositionalArgs(std::vector<const char *> Args, CompileJobAnalyzer CompileAnalyzer; - for (driver::JobList::const_iterator I = Jobs.begin(), E = Jobs.end(); I != E; - ++I) { - if ((*I)->getKind() == driver::Job::CommandClass) { - const driver::Command &Cmd = cast<driver::Command>(**I); + for (const auto &Job : Jobs) { + if (Job.getKind() == driver::Job::CommandClass) { + const driver::Command &Cmd = cast<driver::Command>(Job); // Collect only for Assemble jobs. If we do all jobs we get duplicates // since Link jobs point to Assemble jobs as inputs. if (Cmd.getSource().getKind() == driver::Action::AssembleJobClass) |