diff options
| author | Jordy Rose <jediknil@belkadan.com> | 2011-08-31 18:33:45 +0000 |
|---|---|---|
| committer | Jordy Rose <jediknil@belkadan.com> | 2011-08-31 18:33:45 +0000 |
| commit | 973a8886f641da258229868f524d48769ea21512 (patch) | |
| tree | 0b3f0f475c372952c2345204d6bf943bdd7c40fc /clang/lib/StaticAnalyzer | |
| parent | 5c160fd2435e721d453e37b2c64a80be5316ae10 (diff) | |
| download | bcm5719-llvm-973a8886f641da258229868f524d48769ea21512.tar.gz bcm5719-llvm-973a8886f641da258229868f524d48769ea21512.zip | |
[analyzer] Fix varargs helper to only use POD types even for named arguments. Thanks, Joerg.
llvm-svn: 138875
Diffstat (limited to 'clang/lib/StaticAnalyzer')
| -rw-r--r-- | clang/lib/StaticAnalyzer/Checkers/NoReturnFunctionChecker.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/clang/lib/StaticAnalyzer/Checkers/NoReturnFunctionChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/NoReturnFunctionChecker.cpp index f713bc648b2..80c4d33947a 100644 --- a/clang/lib/StaticAnalyzer/Checkers/NoReturnFunctionChecker.cpp +++ b/clang/lib/StaticAnalyzer/Checkers/NoReturnFunctionChecker.cpp @@ -79,14 +79,14 @@ void NoReturnFunctionChecker::checkPostStmt(const CallExpr *CE, C.generateSink(CE); } -static bool END_WITH_NULL isMultiArgSelector(Selector Sel, ...) { +static bool END_WITH_NULL isMultiArgSelector(const Selector *Sel, ...) { va_list argp; va_start(argp, Sel); unsigned Slot = 0; const char *Arg; while ((Arg = va_arg(argp, const char *))) { - if (!Sel.getNameForSlot(Slot).equals(Arg)) + if (!Sel->getNameForSlot(Slot).equals(Arg)) break; // still need to va_end! ++Slot; } @@ -124,12 +124,12 @@ void NoReturnFunctionChecker::checkPostObjCMessage(const ObjCMessage &Msg, default: return; case 4: - if (!isMultiArgSelector(Sel, "handleFailureInFunction", "file", + if (!isMultiArgSelector(&Sel, "handleFailureInFunction", "file", "lineNumber", "description", NULL)) return; break; case 5: - if (!isMultiArgSelector(Sel, "handleFailureInMethod", "object", "file", + if (!isMultiArgSelector(&Sel, "handleFailureInMethod", "object", "file", "lineNumber", "description", NULL)) return; break; |

