diff options
author | George Karpenkov <ekarpenkov@apple.com> | 2018-11-30 02:18:10 +0000 |
---|---|---|
committer | George Karpenkov <ekarpenkov@apple.com> | 2018-11-30 02:18:10 +0000 |
commit | 3bdbeb155b3fd30e86df2accc324595fa06a47a5 (patch) | |
tree | ba40cbe741b641c8ab8fc83dc5cd7864c3d0aa90 /clang/lib/StaticAnalyzer/Core/RetainSummaryManager.cpp | |
parent | e2f09542a5decacbdebea73e4186dd267f123b52 (diff) | |
download | bcm5719-llvm-3bdbeb155b3fd30e86df2accc324595fa06a47a5.tar.gz bcm5719-llvm-3bdbeb155b3fd30e86df2accc324595fa06a47a5.zip |
[analyzer] For OSObject, trust that functions starting with Get
(uppercase) are also getters.
Differential Revision: https://reviews.llvm.org/D55035
llvm-svn: 347945
Diffstat (limited to 'clang/lib/StaticAnalyzer/Core/RetainSummaryManager.cpp')
-rw-r--r-- | clang/lib/StaticAnalyzer/Core/RetainSummaryManager.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/clang/lib/StaticAnalyzer/Core/RetainSummaryManager.cpp b/clang/lib/StaticAnalyzer/Core/RetainSummaryManager.cpp index 2fb0d754d97..cbaee85beb7 100644 --- a/clang/lib/StaticAnalyzer/Core/RetainSummaryManager.cpp +++ b/clang/lib/StaticAnalyzer/Core/RetainSummaryManager.cpp @@ -241,7 +241,9 @@ RetainSummaryManager::generateSummary(const FunctionDecl *FD, // All objects returned with functions *not* starting with // get, or iterators, are returned at +1. - if (!II->getName().startswith("get") || isOSIteratorSubclass(PD)) { + if ((!II->getName().startswith("get") && + !II->getName().startswith("Get")) || + isOSIteratorSubclass(PD)) { return getOSSummaryCreateRule(FD); } else { return getOSSummaryGetRule(FD); |