summaryrefslogtreecommitdiffstats
path: root/clang/lib/StaticAnalyzer/Core/ExplodedGraph.cpp
diff options
context:
space:
mode:
authorAnna Zaks <ganna@apple.com>2012-06-01 23:48:44 +0000
committerAnna Zaks <ganna@apple.com>2012-06-01 23:48:44 +0000
commitbec49efdf2d7fe33a064a3e9faffa7704df87593 (patch)
tree3898a661532251c569ad9d696da686b66e9248dd /clang/lib/StaticAnalyzer/Core/ExplodedGraph.cpp
parent1b37ea0a5fd0e4a3cc6187644de9f5e5ad8b7e7a (diff)
downloadbcm5719-llvm-bec49efdf2d7fe33a064a3e9faffa7704df87593.tar.gz
bcm5719-llvm-bec49efdf2d7fe33a064a3e9faffa7704df87593.zip
[analyzer] Fix a spurious undef value warning.
When we timeout or exceed a max number of blocks within an inlined function, we retry with no inlining starting from a node right before the CallEnter node. We assume the state of that node is the state of the program before we start evaluating the call. However, the node pruning removes this node as unimportant. Teach the node pruning to keep the predecessors of the call enter nodes. llvm-svn: 157860
Diffstat (limited to 'clang/lib/StaticAnalyzer/Core/ExplodedGraph.cpp')
-rw-r--r--clang/lib/StaticAnalyzer/Core/ExplodedGraph.cpp10
1 files changed, 9 insertions, 1 deletions
diff --git a/clang/lib/StaticAnalyzer/Core/ExplodedGraph.cpp b/clang/lib/StaticAnalyzer/Core/ExplodedGraph.cpp
index e433c353c1c..5b9f451e971 100644
--- a/clang/lib/StaticAnalyzer/Core/ExplodedGraph.cpp
+++ b/clang/lib/StaticAnalyzer/Core/ExplodedGraph.cpp
@@ -67,6 +67,8 @@ bool ExplodedGraph::shouldCollect(const ExplodedNode *node) {
// (6) The 'GDM' is the same as the predecessor.
// (7) The LocationContext is the same as the predecessor.
// (8) The PostStmt is for a non-consumed Stmt or Expr.
+ // (9) The successor is a CallExpr StmtPoint (so that we would be able to
+ // find it when retrying a call with no inlining).
// Conditions 1 and 2.
if (node->pred_size() != 1 || node->succ_size() != 1)
@@ -109,7 +111,13 @@ bool ExplodedGraph::shouldCollect(const ExplodedNode *node) {
return false;
}
- return true;
+ // Condition 9.
+ const ProgramPoint SuccLoc = succ->getLocation();
+ if (const StmtPoint *SP = dyn_cast<StmtPoint>(&SuccLoc))
+ if (isa<CallExpr>(SP->getStmt()))
+ return false;
+
+ return true;
}
void ExplodedGraph::collectNode(ExplodedNode *node) {
OpenPOWER on IntegriCloud