[analyzer] Address Jordan’s code review for r183451

llvm-svn: 183455

1 files changed, 3 insertions, 3 deletions

diff --git a/clang/lib/StaticAnalyzer/Core/BugReporter.cpp b/clang/lib/StaticAnalyzer/Core/BugReporter.cpp
index e3f43854d63..e93bb3fce5e 100644
--- a/clang/lib/StaticAnalyzer/Core/BugReporter.cpp
+++ b/clang/lib/StaticAnalyzer/Core/BugReporter.cpp
@@ -248,7 +248,7 @@ static void adjustCallLocations(PathPieces &Pieces,
 /// We might have pieces with invalid locations as a result of inlining Body
 /// Farm generated functions.
 static void removePiecesWithInvalidLocations(PathPieces &Pieces) {
-  for (PathPieces::iterator I = Pieces.begin(), E = Pieces.end(); I != E; ++I) {
+  for (PathPieces::iterator I = Pieces.begin(), E = Pieces.end(); I != E;) {
     if (PathDiagnosticCallPiece *C = dyn_cast<PathDiagnosticCallPiece>(*I))
       removePiecesWithInvalidLocations(C->path);
 
@@ -257,10 +257,10 @@ static void removePiecesWithInvalidLocations(PathPieces &Pieces) {
 
     if (!(*I)->getLocation().isValid() ||
         !(*I)->getLocation().asLocation().isValid()) {
-      Pieces.erase(I);
+      I = Pieces.erase(I);
       continue;
     }
-    
+    I++;
   }
 }