diff options
| author | Kristof Umann <dkszelethus@gmail.com> | 2019-01-26 21:41:50 +0000 |
|---|---|---|
| committer | Kristof Umann <dkszelethus@gmail.com> | 2019-01-26 21:41:50 +0000 |
| commit | 204bf2bbb265b5158783bacf9a67b0bc4cc57747 (patch) | |
| tree | 15fd00c3646787c7b471644e014b5f1c4b9228f2 /clang/lib/StaticAnalyzer/Checkers/ValistChecker.cpp | |
| parent | a914fa4dd881af669dba66e68677116f0436d1ed (diff) | |
| download | bcm5719-llvm-204bf2bbb265b5158783bacf9a67b0bc4cc57747.tar.gz bcm5719-llvm-204bf2bbb265b5158783bacf9a67b0bc4cc57747.zip | |
[analyzer] Add CheckerManager::getChecker, make sure that a registry function registers no more than 1 checker
This patch effectively fixes the almost decade old checker naming issue.
The solution is to assert when CheckerManager::getChecker is called on an
unregistered checker, and assert when CheckerManager::registerChecker is called
on a checker that is already registered.
Differential Revision: https://reviews.llvm.org/D55429
llvm-svn: 352292
Diffstat (limited to 'clang/lib/StaticAnalyzer/Checkers/ValistChecker.cpp')
| -rw-r--r-- | clang/lib/StaticAnalyzer/Checkers/ValistChecker.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/clang/lib/StaticAnalyzer/Checkers/ValistChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/ValistChecker.cpp index d3eb5063120..13ad3d98e8e 100644 --- a/clang/lib/StaticAnalyzer/Checkers/ValistChecker.cpp +++ b/clang/lib/StaticAnalyzer/Checkers/ValistChecker.cpp @@ -409,7 +409,7 @@ bool ento::shouldRegisterValistBase(const LangOptions &LO) { #define REGISTER_CHECKER(name) \ void ento::register##name##Checker(CheckerManager &mgr) { \ - ValistChecker *checker = mgr.registerChecker<ValistChecker>(); \ + ValistChecker *checker = mgr.getChecker<ValistChecker>(); \ checker->ChecksEnabled[ValistChecker::CK_##name] = true; \ checker->CheckNames[ValistChecker::CK_##name] = mgr.getCurrentCheckName(); \ } \ |
