diff options
author | Anna Zaks <ganna@apple.com> | 2012-08-24 01:39:13 +0000 |
---|---|---|
committer | Anna Zaks <ganna@apple.com> | 2012-08-24 01:39:13 +0000 |
commit | 6fb4b055fba7df6f7d462ef5e8121ec25e6cc954 (patch) | |
tree | ec57e041250b87f1be1cff50d9cfd5eb41615a4f /clang/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp | |
parent | 5e52c2862aa869c9db2b1aa578ef2ab633b0bc8c (diff) | |
download | bcm5719-llvm-6fb4b055fba7df6f7d462ef5e8121ec25e6cc954.tar.gz bcm5719-llvm-6fb4b055fba7df6f7d462ef5e8121ec25e6cc954.zip |
[analyzer] Remove unnecessary code.
This code has been added a while ago and removing it does not trigger
any test failures. The false positives it was trying to suppress are
probably handled by other logic (ex: special handling of delegates).
llvm-svn: 162529
Diffstat (limited to 'clang/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp')
-rw-r--r-- | clang/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp | 16 |
1 files changed, 0 insertions, 16 deletions
diff --git a/clang/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp index ab8acb18318..dc5731b1f0e 100644 --- a/clang/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp +++ b/clang/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp @@ -1358,22 +1358,6 @@ RetainSummaryManager::updateSummaryFromAnnotations(const RetainSummary *&Summ, const RetainSummary * RetainSummaryManager::getStandardMethodSummary(const ObjCMethodDecl *MD, Selector S, QualType RetTy) { - - if (MD) { - // Scan the method decl for 'void*' arguments. These should be treated - // as 'StopTracking' because they are often used with delegates. - // Delegates are a frequent form of false positives with the retain - // count checker. - unsigned i = 0; - for (ObjCMethodDecl::param_const_iterator I = MD->param_begin(), - E = MD->param_end(); I != E; ++I, ++i) - if (const ParmVarDecl *PD = *I) { - QualType Ty = Ctx.getCanonicalType(PD->getType()); - if (Ty.getLocalUnqualifiedType() == Ctx.VoidPtrTy) - ScratchArgs = AF.add(ScratchArgs, i, StopTracking); - } - } - // Any special effects? ArgEffect ReceiverEff = DoNothing; RetEffect ResultEff = RetEffect::MakeNoRet(); |