summaryrefslogtreecommitdiffstats
path: root/clang/lib/StaticAnalyzer/Checkers/ObjCUnusedIVarsChecker.cpp
diff options
context:
space:
mode:
authorDavid Blaikie <dblaikie@gmail.com>2012-06-06 20:45:41 +0000
committerDavid Blaikie <dblaikie@gmail.com>2012-06-06 20:45:41 +0000
commit40ed29730b2656796cd6085148f7aef1886040cf (patch)
tree939094a1639d8564f8e5044bef548315b588ff32 /clang/lib/StaticAnalyzer/Checkers/ObjCUnusedIVarsChecker.cpp
parent3f87e3b7073a954b9f1a600e0cf8149e1e043134 (diff)
downloadbcm5719-llvm-40ed29730b2656796cd6085148f7aef1886040cf.tar.gz
bcm5719-llvm-40ed29730b2656796cd6085148f7aef1886040cf.zip
Revert Decl's iterators back to pointer value_type rather than reference value_type
In addition, I've made the pointer and reference typedef 'void' rather than T* just so they can't get misused. I would've omitted them entirely but std::distance likes them to be there even if it doesn't use them. This rolls back r155808 and r155869. Review by Doug Gregor incorporating feedback from Chandler Carruth. llvm-svn: 158104
Diffstat (limited to 'clang/lib/StaticAnalyzer/Checkers/ObjCUnusedIVarsChecker.cpp')
-rw-r--r--clang/lib/StaticAnalyzer/Checkers/ObjCUnusedIVarsChecker.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/clang/lib/StaticAnalyzer/Checkers/ObjCUnusedIVarsChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/ObjCUnusedIVarsChecker.cpp
index 8792144ddef..582269c3327 100644
--- a/clang/lib/StaticAnalyzer/Checkers/ObjCUnusedIVarsChecker.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/ObjCUnusedIVarsChecker.cpp
@@ -85,7 +85,7 @@ static void Scan(IvarUsageMap& M, const ObjCContainerDecl *D) {
// to an ivar.
for (ObjCImplementationDecl::propimpl_iterator I = ID->propimpl_begin(),
E = ID->propimpl_end(); I!=E; ++I)
- Scan(M, &*I);
+ Scan(M, *I);
// Scan the associated categories as well.
for (const ObjCCategoryDecl *CD =
@@ -118,7 +118,7 @@ static void checkObjCUnusedIvar(const ObjCImplementationDecl *D,
for (ObjCInterfaceDecl::ivar_iterator I=ID->ivar_begin(),
E=ID->ivar_end(); I!=E; ++I) {
- const ObjCIvarDecl *ID = &*I;
+ const ObjCIvarDecl *ID = *I;
// Ignore ivars that...
// (a) aren't private
OpenPOWER on IntegriCloud