diff options
| author | Artem Dergachev <artem.dergachev@gmail.com> | 2019-12-18 13:19:44 -0800 |
|---|---|---|
| committer | Artem Dergachev <artem.dergachev@gmail.com> | 2019-12-18 14:19:17 -0800 |
| commit | bce1cce6bf1286541c57690ab1129fbc02c60f93 (patch) | |
| tree | 4cf25681fce27f6ddb0180fea571a739ad98a615 /clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp | |
| parent | 997bc8b2e6b973dd8c9b17414310cac822543f79 (diff) | |
| download | bcm5719-llvm-bce1cce6bf1286541c57690ab1129fbc02c60f93.tar.gz bcm5719-llvm-bce1cce6bf1286541c57690ab1129fbc02c60f93.zip | |
[analyzer] Teach MismatchedDealloc about initWithBytesNoCopy with deallocator.
MallocChecker warns when memory is passed into -[NSData initWithBytesNoCopy]
but isn't allocated by malloc(), because it will be deallocated by free().
However, initWithBytesNoCopy has an overload that takes an arbitrary block
for deallocating the object. If such overload is used, it is no longer
necessary to make sure that the memory is allocated by malloc().
Diffstat (limited to 'clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp')
| -rw-r--r-- | clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp index 01c7afe5204..09306383d53 100644 --- a/clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp +++ b/clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp @@ -1469,6 +1469,9 @@ void MallocChecker::checkPostObjCMessage(const ObjCMethodCall &Call, if (!*FreeWhenDone) return; + if (Call.hasNonZeroCallbackArg()) + return; + bool IsKnownToBeAllocatedMemory; ProgramStateRef State = FreeMemAux(C, Call.getArgExpr(0), Call.getOriginExpr(), C.getState(), |
