Fix bug 10797: Crash: "cast<Ty>() argument of incompatible type!" assert when analyzing ICU.

Patch by Jean-Daniel Dupas. Thanks for spotting and fixing!

llvm-svn: 138757

1 files changed, 4 insertions, 2 deletions

diff --git a/clang/lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp
index 40c9c72dc2a..1c9390217f7 100644
--- a/clang/lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp
@@ -201,9 +201,11 @@ static SymbolRef getSymbolForRegion(CheckerContext &C,
   if (!isa<SymbolicRegion>(R)) {
     // Implicit casts (ex: void* -> char*) can turn Symbolic region into element
     // region, if that is the case, get the underlining region.
-    if (const ElementRegion *ER = dyn_cast<ElementRegion>(R))
+    if (const ElementRegion *ER = dyn_cast<ElementRegion>(R)) {
       R = ER->getAsArrayOffset().getRegion();
-    else
+      if (!isa<SymbolicRegion>(R))
+        return 0;
+    } else
       return 0;
   }
   return cast<SymbolicRegion>(R)->getSymbol();