summaryrefslogtreecommitdiffstats
path: root/clang/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp
diff options
context:
space:
mode:
authorAnna Zaks <ganna@apple.com>2013-01-11 03:52:44 +0000
committerAnna Zaks <ganna@apple.com>2013-01-11 03:52:44 +0000
commit39a769209130bdbf35e3e62f396d0623b83d63f0 (patch)
treecc99529b7f6a74bacd9fd7eec83c1d1455db494b /clang/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp
parentca49e535ae5c42de49cbd2e259d95ed81b9b7623 (diff)
downloadbcm5719-llvm-39a769209130bdbf35e3e62f396d0623b83d63f0.tar.gz
bcm5719-llvm-39a769209130bdbf35e3e62f396d0623b83d63f0.zip
[analyzer] Rename the warning: state the issue before the hint of how it
can be fixed llvm-svn: 172170
Diffstat (limited to 'clang/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp')
-rw-r--r--clang/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp11
1 files changed, 5 insertions, 6 deletions
diff --git a/clang/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp
index 4f2a9097b4f..9d25ce03647 100644
--- a/clang/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp
@@ -408,11 +408,10 @@ void IvarInvalidationChecker::checkASTDecl(const ObjCImplementationDecl *ImplD,
if (!Info.needsInvalidation()) {
SmallString<128> sbuf;
llvm::raw_svector_ostream os(sbuf);
- os << "No invalidation method declared in the @interface for "
- << InterfaceD->getName() << "; ";
assert(FirstIvarDecl);
printIvar(os, FirstIvarDecl, IvarToPopertyMap);
- os << "needs to be invalidated";
+ os << "needs to be invalidated; ";
+ os << "No invalidation method is declared for " << InterfaceD->getName();
PathDiagnosticLocation IvarDecLocation =
PathDiagnosticLocation::createBegin(FirstIvarDecl, BR.getSourceManager());
@@ -473,11 +472,11 @@ void IvarInvalidationChecker::checkASTDecl(const ObjCImplementationDecl *ImplD,
if (!AtImplementationContainsAtLeastOneInvalidationMethod) {
SmallString<128> sbuf;
llvm::raw_svector_ostream os(sbuf);
- os << "No invalidation method defined in the @implementation for "
- << InterfaceD->getName() << "; ";
assert(FirstIvarDecl);
printIvar(os, FirstIvarDecl, IvarToPopertyMap);
- os << "needs to be invalidated";
+ os << "needs to be invalidated; ";
+ os << "No invalidation method is defined in the @implementation for "
+ << InterfaceD->getName();
PathDiagnosticLocation IvarDecLocation =
PathDiagnosticLocation::createBegin(FirstIvarDecl,
OpenPOWER on IntegriCloud