summaryrefslogtreecommitdiffstats
path: root/clang/lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp
diff options
context:
space:
mode:
authorReka Kovacs <rekanikolett@gmail.com>2018-08-03 20:42:02 +0000
committerReka Kovacs <rekanikolett@gmail.com>2018-08-03 20:42:02 +0000
commitbfd9cfdeeb20c0c48c71447140ca0cdc55b7b5dd (patch)
treea15d3029bc65af59d28846ef7179ec7b876909c7 /clang/lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp
parent4dfe279e00d56f23c37a526b3abe0a7c89269fa7 (diff)
downloadbcm5719-llvm-bfd9cfdeeb20c0c48c71447140ca0cdc55b7b5dd.tar.gz
bcm5719-llvm-bfd9cfdeeb20c0c48c71447140ca0cdc55b7b5dd.zip
[analyzer] Add test for a crash fixed in r338775.
Do not crash if a CXXRecordDecl cannot be obtained for an object. Special thanks for the reproduction to Alexander Kornienko. llvm-svn: 338918
Diffstat (limited to 'clang/lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp')
-rw-r--r--clang/lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp5
1 files changed, 1 insertions, 4 deletions
diff --git a/clang/lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp
index b253e67cffd..3a8964bb8d3 100644
--- a/clang/lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp
@@ -133,10 +133,7 @@ bool InnerPointerChecker::isCalledOnStringObject(
return false;
CXXRecordDecl *Decl = ObjTy->getAsCXXRecordDecl();
- if (!Decl || Decl->getName() != "basic_string")
- return false;
-
- return true;
+ return Decl && Decl->getName() == "basic_string";
}
bool InnerPointerChecker::isInvalidatingMemberFunction(
OpenPOWER on IntegriCloud