summaryrefslogtreecommitdiffstats
path: root/clang/lib/Sema
diff options
context:
space:
mode:
authorDaniel Berlin <dberlin@dberlin.org>2017-01-07 19:04:59 +0000
committerDaniel Berlin <dberlin@dberlin.org>2017-01-07 19:04:59 +0000
commitfe4e7d0c94efef838d26e907411058dee1abc72b (patch)
tree8e731dffc7ef773a0cd8b9dd165fefa64d09bc9e /clang/lib/Sema
parent42ef199058972bb2c5df7f46b44218a6838e49c2 (diff)
downloadbcm5719-llvm-fe4e7d0c94efef838d26e907411058dee1abc72b.tar.gz
bcm5719-llvm-fe4e7d0c94efef838d26e907411058dee1abc72b.zip
Update update_test_checks to work properly with phi nodes and other fun things.
Summary: Prior to this change, phi nodes were never considered defs, and so we ended up with undefined variables for any loop. Now, instead of trying to find just defs, we iterate over each actual IR value in the line, and replace them one by one with either a definition or a use. We also don't try to match anything in the comment portions of the line. I've tested it even on things like function pointer calls, etc, and against existing test cases uses update_test_checks With this change, we are able to use update_tests on the cyclic cases in newgvn. The only case i'm aware of that will misfire is if you have a string with which contains a valid token. However, this is the same as it is now, with a slightly larger set of strings that may misfire. Prior to this change, a test with the string " %a =" would be replaced. Reviewers: spatel, chandlerc Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D28384 llvm-svn: 291357
Diffstat (limited to 'clang/lib/Sema')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud