diff options
| author | Ted Kremenek <kremenek@apple.com> | 2014-03-20 06:07:30 +0000 |
|---|---|---|
| committer | Ted Kremenek <kremenek@apple.com> | 2014-03-20 06:07:30 +0000 |
| commit | f3c93bb61b486d3b01de8d0b071688a35388474d (patch) | |
| tree | a6df4a82b892bace12a0bba21e037a882f431f71 /clang/lib/Sema | |
| parent | 39f773f939b33b9f41a8b82a6e386e69750a40a6 (diff) | |
| download | bcm5719-llvm-f3c93bb61b486d3b01de8d0b071688a35388474d.tar.gz bcm5719-llvm-f3c93bb61b486d3b01de8d0b071688a35388474d.zip | |
[-Wunreachable-code] Simplify and broad -Wunreachable-code-return, including nontrivial returns.
The exception is return statements that include control-flow,
which are clearly doing something "interesting".
99% of the cases I examined for -Wunreachable-code that fired
on return statements were not interesting enough to warrant
being in -Wunreachable-code by default. Thus the move to
include them in -Wunreachable-code-return.
This simplifies a bunch of logic, including removing the ad hoc
logic to look for std::string literals.
llvm-svn: 204307
Diffstat (limited to 'clang/lib/Sema')
| -rw-r--r-- | clang/lib/Sema/AnalysisBasedWarnings.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/clang/lib/Sema/AnalysisBasedWarnings.cpp b/clang/lib/Sema/AnalysisBasedWarnings.cpp index 32e40ab2ea9..389109a11bc 100644 --- a/clang/lib/Sema/AnalysisBasedWarnings.cpp +++ b/clang/lib/Sema/AnalysisBasedWarnings.cpp @@ -73,7 +73,7 @@ namespace { case reachable_code::UK_Break: diag = diag::warn_unreachable_break; break; - case reachable_code::UK_TrivialReturn: + case reachable_code::UK_Return: diag = diag::warn_unreachable_return; break; case reachable_code::UK_Other: |
