diff options
| author | Richard Trieu <rtrieu@google.com> | 2014-09-30 23:04:37 +0000 |
|---|---|---|
| committer | Richard Trieu <rtrieu@google.com> | 2014-09-30 23:04:37 +0000 |
| commit | 9f8509f70d0cdec5cb1f4c69a0f218db1a2966d3 (patch) | |
| tree | 1ef7693d20ed1aab18b105141e0fc24f8d78d3b3 /clang/lib/Sema | |
| parent | fd8631798970c5b527ec2ad071fe1582e5146ab5 (diff) | |
| download | bcm5719-llvm-9f8509f70d0cdec5cb1f4c69a0f218db1a2966d3.tar.gz bcm5719-llvm-9f8509f70d0cdec5cb1f4c69a0f218db1a2966d3.zip | |
Update -Wuninitialized to be stricter on CK_NoOp casts.
llvm-svn: 218715
Diffstat (limited to 'clang/lib/Sema')
| -rw-r--r-- | clang/lib/Sema/SemaDecl.cpp | 15 |
1 files changed, 10 insertions, 5 deletions
diff --git a/clang/lib/Sema/SemaDecl.cpp b/clang/lib/Sema/SemaDecl.cpp index 9203df3fe5b..a3227aa2960 100644 --- a/clang/lib/Sema/SemaDecl.cpp +++ b/clang/lib/Sema/SemaDecl.cpp @@ -8404,8 +8404,7 @@ namespace { } void VisitImplicitCastExpr(ImplicitCastExpr *E) { - if (E->getCastKind() == CK_LValueToRValue || - (isRecordType && E->getCastKind() == CK_NoOp)) { + if (E->getCastKind() == CK_LValueToRValue) { HandleValue(E->getSubExpr()); return; } @@ -8473,9 +8472,15 @@ namespace { void VisitCXXConstructExpr(CXXConstructExpr *E) { if (E->getConstructor()->isCopyConstructor()) { - if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E->getArg(0))) { - HandleDeclRefExpr(DRE); - } + Expr *ArgExpr = E->getArg(0); + if (InitListExpr *ILE = dyn_cast<InitListExpr>(ArgExpr)) + if (ILE->getNumInits() == 1) + ArgExpr = ILE->getInit(0); + if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(ArgExpr)) + if (ICE->getCastKind() == CK_NoOp) + ArgExpr = ICE->getSubExpr(); + HandleValue(ArgExpr); + return; } Inherited::VisitCXXConstructExpr(E); } |
