Objective-C ARC [qoi]. Issue diagnostic if __bridge casting

to C type a collection literal. rdar://18768214

llvm-svn: 220727

1 files changed, 16 insertions, 5 deletions

diff --git a/clang/lib/Sema/SemaExprObjC.cpp b/clang/lib/Sema/SemaExprObjC.cpp
index 40ab95b6ec5..5746e732943 100644
--- a/clang/lib/Sema/SemaExprObjC.cpp
+++ b/clang/lib/Sema/SemaExprObjC.cpp
@@ -4075,11 +4075,22 @@ ExprResult Sema::BuildObjCBridgedCast(SourceLocation LParenLoc,
     // Okay: id -> CF
     CK = CK_BitCast;
     switch (Kind) {
-    case OBC_Bridge:
-      // Reclaiming a value that's going to be __bridge-casted to CF
-      // is very dangerous, so we don't do it.
-      SubExpr = maybeUndoReclaimObject(SubExpr);
-      break;
+      case OBC_Bridge: {
+        const ImplicitCastExpr *implCE = dyn_cast<ImplicitCastExpr>(SubExpr);
+        while (implCE && implCE->getCastKind() ==  CK_BitCast)
+          implCE = dyn_cast<ImplicitCastExpr>(implCE->getSubExpr());
+        if (implCE && (implCE->getCastKind() == CK_ARCConsumeObject))
+          if (const Expr *LitExp = implCE->getSubExpr())
+            if ((isa<ObjCArrayLiteral>(LitExp) ||
+                 isa<ObjCDictionaryLiteral>(LitExp)) &&
+                T->isCARCBridgableType())
+              Diag(BridgeKeywordLoc, diag::warn_arc_consumed_object_released)
+                << T << implCE->getType();
+        // Reclaiming a value that's going to be __bridge-casted to CF
+        // is very dangerous, so we don't do it.
+        SubExpr = maybeUndoReclaimObject(SubExpr);
+        break;
+      }
       
     case OBC_BridgeRetained:        
       // Produce the object before casting it.