diff options
| author | David Majnemer <david.majnemer@gmail.com> | 2014-12-15 10:00:35 +0000 |
|---|---|---|
| committer | David Majnemer <david.majnemer@gmail.com> | 2014-12-15 10:00:35 +0000 |
| commit | 7e21745e2249c118ca71dee4aaf1346b12650aea (patch) | |
| tree | 1db785e41a20de0a88f7dee23aeca71bc7dd2192 /clang/lib/Sema | |
| parent | 79c79e3e8a815e778157590bbeea22afaff425f8 (diff) | |
| download | bcm5719-llvm-7e21745e2249c118ca71dee4aaf1346b12650aea.tar.gz bcm5719-llvm-7e21745e2249c118ca71dee4aaf1346b12650aea.zip | |
Sema: Don't diagnose string + int if the int is value dependent
Don't send a value dependent expression into the expression evaluator,
HandleSizeof would crash. Making HandleSizeof handle dependent types
would noisily warn about the operation even if everything turns out OK
after instantiation.
This fixes PR21848.
llvm-svn: 224240
Diffstat (limited to 'clang/lib/Sema')
| -rw-r--r-- | clang/lib/Sema/SemaExpr.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/clang/lib/Sema/SemaExpr.cpp b/clang/lib/Sema/SemaExpr.cpp index c04b99d464c..876e5b71e01 100644 --- a/clang/lib/Sema/SemaExpr.cpp +++ b/clang/lib/Sema/SemaExpr.cpp @@ -7282,7 +7282,7 @@ static void diagnoseStringPlusInt(Sema &Self, SourceLocation OpLoc, bool IsStringPlusInt = StrExpr && IndexExpr->getType()->isIntegralOrUnscopedEnumerationType(); - if (!IsStringPlusInt) + if (!IsStringPlusInt || IndexExpr->isValueDependent()) return; llvm::APSInt index; |
