Add increment/decrement operators and compound assignment operators to the

uninitialized checkers that did not have them before.

llvm-svn: 218435

2 files changed, 27 insertions, 0 deletions

diff --git a/clang/lib/Sema/SemaDecl.cpp b/clang/lib/Sema/SemaDecl.cpp
index 277816be429..1bac28753fe 100644
--- a/clang/lib/Sema/SemaDecl.cpp
+++ b/clang/lib/Sema/SemaDecl.cpp
@@ -8452,6 +8452,12 @@ namespace {
           HandleValue(E->getSubExpr());
         return;
       }
+
+      if (E->isIncrementDecrementOp()) {
+        HandleValue(E->getSubExpr());
+        return;
+      }
+
       Inherited::VisitUnaryOperator(E);
     }
 
@@ -8480,6 +8486,16 @@ namespace {
       Inherited::VisitCallExpr(E);
     }
 
+    void VisitBinaryOperator(BinaryOperator *E) {
+      if (E->isCompoundAssignmentOp()) {
+        HandleValue(E->getLHS());
+        Visit(E->getRHS());
+        return;
+      }
+
+      Inherited::VisitBinaryOperator(E);
+    }
+
     // A custom visitor for BinaryConditionalOperator is needed because the
     // regular visitor would check the condition and true expression separately
     // but both point to the same place giving duplicate diagnostics.
diff --git a/clang/lib/Sema/SemaDeclCXX.cpp b/clang/lib/Sema/SemaDeclCXX.cpp
index 006a3c49d7c..bf53ae38ddb 100644
--- a/clang/lib/Sema/SemaDeclCXX.cpp
+++ b/clang/lib/Sema/SemaDeclCXX.cpp
@@ -2382,8 +2382,19 @@ namespace {
             if (!FD->getType()->isReferenceType())
               DeclsToRemove.push_back(FD);
 
+      if (E->isCompoundAssignmentOp()) {
+        HandleValue(E->getLHS());
+      }
+
       Inherited::VisitBinaryOperator(E);
     }
+
+    void VisitUnaryOperator(UnaryOperator *E) {
+      if (E->isIncrementDecrementOp())
+        HandleValue(E->getSubExpr());
+
+      Inherited::VisitUnaryOperator(E);
+    }
   };
 
   // Diagnose value-uses of fields to initialize themselves, e.g.