diff options
| author | Reid Kleckner <rnk@google.com> | 2016-12-07 00:17:18 +0000 |
|---|---|---|
| committer | Reid Kleckner <rnk@google.com> | 2016-12-07 00:17:18 +0000 |
| commit | 36c201a65af69f3bba9fc55ef28eae7500cde63c (patch) | |
| tree | 31b556c0f47691ccab7739bdf73c2a8b23e317b3 /clang/lib/Sema | |
| parent | 6f0b4f2e89c6d611b7c3f240904c5037206ba1ca (diff) | |
| download | bcm5719-llvm-36c201a65af69f3bba9fc55ef28eae7500cde63c.tar.gz bcm5719-llvm-36c201a65af69f3bba9fc55ef28eae7500cde63c.zip | |
Address review feedback by adding comments about ${:uid}
llvm-svn: 288868
Diffstat (limited to 'clang/lib/Sema')
| -rw-r--r-- | clang/lib/Sema/SemaStmtAsm.cpp | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/clang/lib/Sema/SemaStmtAsm.cpp b/clang/lib/Sema/SemaStmtAsm.cpp index 0064a2c5121..9a182449845 100644 --- a/clang/lib/Sema/SemaStmtAsm.cpp +++ b/clang/lib/Sema/SemaStmtAsm.cpp @@ -750,9 +750,11 @@ LabelDecl *Sema::GetOrCreateMSAsmLabel(StringRef ExternalLabelName, // Otherwise, insert it, but only resolve it if we have seen the label itself. std::string InternalName; llvm::raw_string_ostream OS(InternalName); - // Create an internal name for the label. The name should not be a valid mangled - // name, and should be unique. We use a dot to make the name an invalid mangled - // name. + // Create an internal name for the label. The name should not be a valid + // mangled name, and should be unique. We use a dot to make the name an + // invalid mangled name. We use LLVM's inline asm ${:uid} escape so that a + // unique label is generated each time this blob is emitted, even after + // inlining or LTO. OS << "__MSASMLABEL_.${:uid}__"; for (char C : ExternalLabelName) { OS << C; |

