diff options
author | Richard Smith <richard-llvm@metafoo.co.uk> | 2018-05-14 20:52:48 +0000 |
---|---|---|
committer | Richard Smith <richard-llvm@metafoo.co.uk> | 2018-05-14 20:52:48 +0000 |
commit | cbebd6226dbdd796ed35b40bd35aeb60bf1ada09 (patch) | |
tree | c3ea2c93a53e08f14609aa1864ab99a4919027d9 /clang/lib/Sema/SemaTemplate.cpp | |
parent | f66f7612bf6a0f6f6085056c2083870981d7c2a0 (diff) | |
download | bcm5719-llvm-cbebd6226dbdd796ed35b40bd35aeb60bf1ada09.tar.gz bcm5719-llvm-cbebd6226dbdd796ed35b40bd35aeb60bf1ada09.zip |
Fix regression in r332076.
If the name after 'template' is an unresolved using declaration (not containing
'typename'), then we don't yet know if it's a valid template-name, so don't
reject it prior to instantiation. Instead, treat it as naming a dependent
member of the current instantiation.
llvm-svn: 332291
Diffstat (limited to 'clang/lib/Sema/SemaTemplate.cpp')
-rw-r--r-- | clang/lib/Sema/SemaTemplate.cpp | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/clang/lib/Sema/SemaTemplate.cpp b/clang/lib/Sema/SemaTemplate.cpp index b2ac7d98d54..530fc668f2f 100644 --- a/clang/lib/Sema/SemaTemplate.cpp +++ b/clang/lib/Sema/SemaTemplate.cpp @@ -105,6 +105,12 @@ static NamedDecl *isAcceptableTemplateName(ASTContext &Context, return nullptr; } + // 'using Dependent::foo;' can resolve to a template name. + // 'using typename Dependent::foo;' cannot (not even if 'foo' is an + // injected-class-name). + if (isa<UnresolvedUsingValueDecl>(D)) + return D; + return nullptr; } @@ -214,6 +220,10 @@ TemplateNameKind Sema::isTemplateName(Scope *S, // We'll do this lookup again later. R.suppressDiagnostics(); + } else if (isa<UnresolvedUsingValueDecl>((*R.begin())->getUnderlyingDecl())) { + // We don't yet know whether this is a template-name or not. + MemberOfUnknownSpecialization = true; + return TNK_Non_template; } else { TemplateDecl *TD = cast<TemplateDecl>((*R.begin())->getUnderlyingDecl()); @@ -429,7 +439,7 @@ bool Sema::LookupTemplateName(LookupResult &Found, if (ExampleLookupResult && TemplateKWLoc.isValid()) { Diag(Found.getNameLoc(), diag::err_template_kw_refers_to_non_template) << Found.getLookupName() << SS.getRange(); - Diag(ExampleLookupResult->getLocation(), + Diag(ExampleLookupResult->getUnderlyingDecl()->getLocation(), diag::note_template_kw_refers_to_non_template) << Found.getLookupName(); return true; |