diff options
author | Anders Carlsson <andersca@mac.com> | 2008-11-22 21:50:49 +0000 |
---|---|---|
committer | Anders Carlsson <andersca@mac.com> | 2008-11-22 21:50:49 +0000 |
commit | 475f4bce36ae8cd2f727f9b2350a5cbf9d70df0c (patch) | |
tree | cc6deeacf8177e0b8c182c238e8b0ef115ffb3c9 /clang/lib/Sema/SemaStmt.cpp | |
parent | e72a8a30480606ea9296d06e10f1b33402bc355b (diff) | |
download | bcm5719-llvm-475f4bce36ae8cd2f727f9b2350a5cbf9d70df0c.tar.gz bcm5719-llvm-475f4bce36ae8cd2f727f9b2350a5cbf9d70df0c.zip |
Case values must be evaluated
llvm-svn: 59884
Diffstat (limited to 'clang/lib/Sema/SemaStmt.cpp')
-rw-r--r-- | clang/lib/Sema/SemaStmt.cpp | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/clang/lib/Sema/SemaStmt.cpp b/clang/lib/Sema/SemaStmt.cpp index 6839310e0ec..15d955cb7b4 100644 --- a/clang/lib/Sema/SemaStmt.cpp +++ b/clang/lib/Sema/SemaStmt.cpp @@ -131,8 +131,10 @@ Sema::ActOnCaseStmt(SourceLocation CaseLoc, ExprTy *lhsval, // However, GCC allows any evaluatable integer expression. // FIXME: Should we warn if this is evaluatable but not an I-C-E? APValue Result; + bool isEvaluated; - if (!LHSVal->Evaluate(Result, Context) || !Result.isInt()) { + if (!LHSVal->Evaluate(Result, Context, &isEvaluated) || !Result.isInt() || + !isEvaluated) { // FIXME: Evaluate doesn't return the SourceLocation that it failed to // evaluate. ExpLoc = LHSVal->getExprLoc(); @@ -142,7 +144,8 @@ Sema::ActOnCaseStmt(SourceLocation CaseLoc, ExprTy *lhsval, } // GCC extension: The expression shall be an integer constant. - if (RHSVal && !RHSVal->Evaluate(Result, Context) || !Result.isInt()) { + if (RHSVal && !RHSVal->Evaluate(Result, Context, &isEvaluated) || + !Result.isInt() || !isEvaluated) { ExpLoc = RHSVal->getExprLoc(); Diag(ExpLoc, diag::err_case_label_not_integer_constant_expr) << RHSVal->getSourceRange(); |