diff options
| author | Reid Kleckner <rnk@google.com> | 2018-08-17 22:11:31 +0000 |
|---|---|---|
| committer | Reid Kleckner <rnk@google.com> | 2018-08-17 22:11:31 +0000 |
| commit | 4c33d197fa77b9434a7e76d9ee80005de58a0026 (patch) | |
| tree | 6922ab29026ea7ae2d149c45238b582382b3e80e /clang/lib/Sema/SemaInit.cpp | |
| parent | 26f6176f38fbe48df500ed08ff4ae1a11b1aa608 (diff) | |
| download | bcm5719-llvm-4c33d197fa77b9434a7e76d9ee80005de58a0026.tar.gz bcm5719-llvm-4c33d197fa77b9434a7e76d9ee80005de58a0026.zip | |
Don't warn on returning the address of a label from a statement expression
Summary:
There isn't anything inherently wrong with returning a label from a
statement expression. In practice, the Linux kernel uses this pattern to
materialize PCs.
Fixes PR38569
Reviewers: niravd, rsmith, nickdesaulniers
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D50805
llvm-svn: 340101
Diffstat (limited to 'clang/lib/Sema/SemaInit.cpp')
| -rw-r--r-- | clang/lib/Sema/SemaInit.cpp | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/clang/lib/Sema/SemaInit.cpp b/clang/lib/Sema/SemaInit.cpp index 766f23b05b0..1f28056e254 100644 --- a/clang/lib/Sema/SemaInit.cpp +++ b/clang/lib/Sema/SemaInit.cpp @@ -6924,6 +6924,10 @@ void Sema::checkInitializerLifetime(const InitializedEntity &Entity, } else if (isa<BlockExpr>(L)) { Diag(DiagLoc, diag::err_ret_local_block) << DiagRange; } else if (isa<AddrLabelExpr>(L)) { + // Don't warn when returning a label from a statement expression. + // Leaving the scope doesn't end its lifetime. + if (LK == LK_StmtExprResult) + return false; Diag(DiagLoc, diag::warn_ret_addr_label) << DiagRange; } else { Diag(DiagLoc, diag::warn_ret_local_temp_addr_ref) |
