objective-c: warn on use of property setters

backing two propeties because proprty names
match except for first letter being of different
case. // rdar://11528439, [PR12936].

llvm-svn: 157435

1 files changed, 5 insertions, 6 deletions

diff --git a/clang/lib/Sema/SemaExprObjC.cpp b/clang/lib/Sema/SemaExprObjC.cpp
index 52e093c85b0..9ce0fafe3c1 100644
--- a/clang/lib/Sema/SemaExprObjC.cpp
+++ b/clang/lib/Sema/SemaExprObjC.cpp
@@ -1415,8 +1415,7 @@ HandleExprPropertyRefExpr(const ObjCObjectPointerType *OPT,
     return ExprError();
   
   // Search for a declared property first.
-  ObjCPropertyDecl *PD = IFace->FindPropertyDeclaration(Member);
-  if (PD) {
+  if (ObjCPropertyDecl *PD = IFace->FindPropertyDeclaration(Member)) {
     // Check whether we can reference this property.
     if (DiagnoseUseOfDecl(PD, MemberLoc))
       return ExprError();
@@ -1484,11 +1483,11 @@ HandleExprPropertyRefExpr(const ObjCObjectPointerType *OPT,
     SelectorTable::constructSetterName(PP.getIdentifierTable(),
                                        PP.getSelectorTable(), Member);
   ObjCMethodDecl *Setter = IFace->lookupInstanceMethod(SetterSel);
-  // Check for corner case of: @property int p; ... self.P = 0;
-  // setter name is synthesized "setP" but there is no property name 'P'.
-  if (Setter && Setter->isSynthesized() && !PD)
+  if (Setter && Setter->isSynthesized())
+    // Check for corner case of: @property int p; ... self.P = 0;
+    // setter name is synthesized "setP" but there is no property name 'P'.
     Setter = 0;
-  
+      
   // May be founf in property's qualified list.
   if (!Setter)
     Setter = LookupMethodInQualifiedType(SetterSel, OPT, true);