summaryrefslogtreecommitdiffstats
path: root/clang/lib/Sema/SemaExprMember.cpp
diff options
context:
space:
mode:
authorEric Fiselier <eric@efcs.ca>2018-04-08 06:21:33 +0000
committerEric Fiselier <eric@efcs.ca>2018-04-08 06:21:33 +0000
commit4b8c991870a03d6e526610cd20da75d2c96b910f (patch)
tree594b91926f1d6c42dcdf8bf916f56949e58890af /clang/lib/Sema/SemaExprMember.cpp
parent80440deed41d88ddae7edca3ae8a56b4dbccc67e (diff)
downloadbcm5719-llvm-4b8c991870a03d6e526610cd20da75d2c96b910f.tar.gz
bcm5719-llvm-4b8c991870a03d6e526610cd20da75d2c96b910f.zip
[Sema] Fix PR35832 - Ambiguity accessing anonymous struct/union with multiple bases.
Summary: Currently clang doesn't do qualified lookup when building indirect field decl references. This causes ambiguity when the field is in a base class to which there are multiple valid paths even though a qualified name is used. For example: ``` class B { protected: int i; union { int j; }; }; class X : public B { }; class Y : public B { }; class Z : public X, public Y { int a() { return X::i; } // works int b() { return X::j; } // fails }; ``` Reviewers: rsmith, aaron.ballman, rjmccall Reviewed By: rjmccall Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D45411 llvm-svn: 329521
Diffstat (limited to 'clang/lib/Sema/SemaExprMember.cpp')
-rw-r--r--clang/lib/Sema/SemaExprMember.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/clang/lib/Sema/SemaExprMember.cpp b/clang/lib/Sema/SemaExprMember.cpp
index c737d7bfd44..680ca99d660 100644
--- a/clang/lib/Sema/SemaExprMember.cpp
+++ b/clang/lib/Sema/SemaExprMember.cpp
@@ -848,7 +848,7 @@ Sema::BuildAnonymousStructUnionMemberReference(const CXXScopeSpec &SS,
// Build the first member access in the chain with full information.
result =
BuildFieldReferenceExpr(result, baseObjectIsPointer, SourceLocation(),
- EmptySS, field, foundDecl, memberNameInfo)
+ SS, field, foundDecl, memberNameInfo)
.get();
if (!result)
return ExprError();
OpenPOWER on IntegriCloud