diff options
| author | Richard Smith <richard@metafoo.co.uk> | 2020-01-09 19:22:52 -0800 |
|---|---|---|
| committer | Richard Smith <richard@metafoo.co.uk> | 2020-01-10 16:12:00 -0800 |
| commit | fbf915f01d46e005146f01553a5d7c6619d19597 (patch) | |
| tree | c557a3cc30177285335f34c21fe006a56a7e2792 /clang/lib/Sema/SemaExpr.cpp | |
| parent | f4df7f4701d80ce6a2f5674db50f87fbd2dad82f (diff) | |
| download | bcm5719-llvm-fbf915f01d46e005146f01553a5d7c6619d19597.tar.gz bcm5719-llvm-fbf915f01d46e005146f01553a5d7c6619d19597.zip | |
Add a FIXME and corresponding test coverage for some suspicious behavior
forming composite ObjC pointer types in comparisons.
Diffstat (limited to 'clang/lib/Sema/SemaExpr.cpp')
| -rw-r--r-- | clang/lib/Sema/SemaExpr.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/clang/lib/Sema/SemaExpr.cpp b/clang/lib/Sema/SemaExpr.cpp index 51b1ebe0b17..5f4071924d3 100644 --- a/clang/lib/Sema/SemaExpr.cpp +++ b/clang/lib/Sema/SemaExpr.cpp @@ -11055,6 +11055,9 @@ QualType Sema::CheckCompareOperands(ExprResult &LHS, ExprResult &RHS, diagnoseDistinctPointerComparison(*this, Loc, LHS, RHS, /*isError*/false); } + // FIXME: If LPtrToVoid, we should presumably convert the LHS rather than + // the RHS, but we have test coverage for this behavior. + // FIXME: Consider using convertPointersToCompositeType in C++. if (LHSIsNull && !RHSIsNull) { Expr *E = LHS.get(); if (getLangOpts().ObjCAutoRefCount) |
