diff options
| author | John McCall <rjmccall@apple.com> | 2010-03-11 19:43:18 +0000 |
|---|---|---|
| committer | John McCall <rjmccall@apple.com> | 2010-03-11 19:43:18 +0000 |
| commit | 71d8d9b4688b09f78c50fc303100f45e389952b1 (patch) | |
| tree | 0efc22f14c1e66696e30a6df3a7b6394d82b21ec /clang/lib/Sema/SemaExpr.cpp | |
| parent | 2562356992ba1f57f2302f4fcf25ad84dad8990e (diff) | |
| download | bcm5719-llvm-71d8d9b4688b09f78c50fc303100f45e389952b1.tar.gz bcm5719-llvm-71d8d9b4688b09f78c50fc303100f45e389952b1.zip | |
Warn about comparing an unsigned expression with 0 in tautological ways.
Patch by mikem!
llvm-svn: 98279
Diffstat (limited to 'clang/lib/Sema/SemaExpr.cpp')
| -rw-r--r-- | clang/lib/Sema/SemaExpr.cpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/clang/lib/Sema/SemaExpr.cpp b/clang/lib/Sema/SemaExpr.cpp index 2249579ba4e..5d352ceb047 100644 --- a/clang/lib/Sema/SemaExpr.cpp +++ b/clang/lib/Sema/SemaExpr.cpp @@ -4105,7 +4105,7 @@ QualType Sema::CheckConditionalOperands(Expr *&Cond, Expr *&LHS, Expr *&RHS, if (getLangOptions().CPlusPlus) return CXXCheckConditionalOperands(Cond, LHS, RHS, QuestionLoc); - CheckSignCompare(LHS, RHS, QuestionLoc, diag::warn_mixed_sign_conditional); + CheckSignCompare(LHS, RHS, QuestionLoc); UsualUnaryConversions(Cond); UsualUnaryConversions(LHS); @@ -5282,8 +5282,7 @@ QualType Sema::CheckCompareOperands(Expr *&lex, Expr *&rex, SourceLocation Loc, if (lex->getType()->isVectorType() || rex->getType()->isVectorType()) return CheckVectorCompareOperands(lex, rex, Loc, isRelational); - CheckSignCompare(lex, rex, Loc, diag::warn_mixed_sign_comparison, - (Opc == BinaryOperator::EQ || Opc == BinaryOperator::NE)); + CheckSignCompare(lex, rex, Loc, &Opc); // C99 6.5.8p3 / C99 6.5.9p4 if (lex->getType()->isArithmeticType() && rex->getType()->isArithmeticType()) |
