diff options
| author | David Bolvansky <david.bolvansky@gmail.com> | 2019-09-03 10:32:21 +0000 |
|---|---|---|
| committer | David Bolvansky <david.bolvansky@gmail.com> | 2019-09-03 10:32:21 +0000 |
| commit | c50da3d0525c52625ad5bb5e950cdf3f7b2dcbbd (patch) | |
| tree | b47cccbb2a881c61f4c796d6f6c032e21bb020f6 /clang/lib/Sema/SemaDeclCXX.cpp | |
| parent | 25d5b54542e0b41dbb14e3771388677c4b9703cc (diff) | |
| download | bcm5719-llvm-c50da3d0525c52625ad5bb5e950cdf3f7b2dcbbd.tar.gz bcm5719-llvm-c50da3d0525c52625ad5bb5e950cdf3f7b2dcbbd.zip | |
Added fixit notes for -Wfinal-dtor-non-final-class
llvm-svn: 370737
Diffstat (limited to 'clang/lib/Sema/SemaDeclCXX.cpp')
| -rw-r--r-- | clang/lib/Sema/SemaDeclCXX.cpp | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/clang/lib/Sema/SemaDeclCXX.cpp b/clang/lib/Sema/SemaDeclCXX.cpp index a5b4eda43c5..e2f0aef7bf6 100644 --- a/clang/lib/Sema/SemaDeclCXX.cpp +++ b/clang/lib/Sema/SemaDeclCXX.cpp @@ -6241,10 +6241,14 @@ void Sema::CheckCompletedCXXClass(CXXRecordDecl *Record) { if (const CXXDestructorDecl *dtor = Record->getDestructor()) { if (const FinalAttr *FA = dtor->getAttr<FinalAttr>()) { Diag(FA->getLocation(), diag::warn_final_dtor_non_final_class) - << FA->isSpelledAsSealed(); - Diag(Record->getLocation(), diag::note_final_dtor_non_final_class_silence) - << Context.getRecordType(Record) - << FA->isSpelledAsSealed(); + << FA->isSpelledAsSealed() + << FixItHint::CreateRemoval(FA->getLocation()) + << FixItHint::CreateInsertion( + getLocForEndOfToken(Record->getLocation()), + (FA->isSpelledAsSealed() ? " sealed" : " final")); + Diag(Record->getLocation(), + diag::note_final_dtor_non_final_class_silence) + << Context.getRecordType(Record) << FA->isSpelledAsSealed(); } } } |
