diff options
| author | Dávid Bolvanský <david.bolvansky@gmail.com> | 2019-11-22 22:37:07 +0100 |
|---|---|---|
| committer | Dávid Bolvanský <david.bolvansky@gmail.com> | 2019-11-22 22:37:19 +0100 |
| commit | 9353c5dd0664ea444236e527bf93566e11dc34df (patch) | |
| tree | 7feded4967a9c68f6d4795c63beb643299d21c6e /clang/lib/Sema/SemaDeclCXX.cpp | |
| parent | c32f0ff92f024a8af438fc8d85906e441b5a2682 (diff) | |
| download | bcm5719-llvm-9353c5dd0664ea444236e527bf93566e11dc34df.tar.gz bcm5719-llvm-9353c5dd0664ea444236e527bf93566e11dc34df.zip | |
[Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy
Summary:
GCC 9 added -Wdeprecated-copy (as part of -Wextra). This diagnostic is already implemented in Clang too, just hidden under -Wdeprecated (not on by default).
This patch adds -Wdeprecated-copy and makes it compatible with GCC 9+.
This diagnostic is heavily tested in deprecated.cpp, so I added simple tests just to check we warn when new flag/-Wextra is enabled.
Reviewers: rsmith, dblaikie
Reviewed By: dblaikie
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D70342
Diffstat (limited to 'clang/lib/Sema/SemaDeclCXX.cpp')
| -rw-r--r-- | clang/lib/Sema/SemaDeclCXX.cpp | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/clang/lib/Sema/SemaDeclCXX.cpp b/clang/lib/Sema/SemaDeclCXX.cpp index 14989cd9b42..d7200185bdf 100644 --- a/clang/lib/Sema/SemaDeclCXX.cpp +++ b/clang/lib/Sema/SemaDeclCXX.cpp @@ -12434,9 +12434,10 @@ static void diagnoseDeprecatedCopyOperation(Sema &S, CXXMethodDecl *CopyOp) { if (UserDeclaredOperation) { S.Diag(UserDeclaredOperation->getLocation(), - diag::warn_deprecated_copy_operation) - << RD << /*copy assignment*/!isa<CXXConstructorDecl>(CopyOp) - << /*destructor*/isa<CXXDestructorDecl>(UserDeclaredOperation); + isa<CXXDestructorDecl>(UserDeclaredOperation) + ? diag::warn_deprecated_copy_dtor_operation + : diag::warn_deprecated_copy_operation) + << RD << /*copy assignment*/ !isa<CXXConstructorDecl>(CopyOp); } } |
